open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `aircookie/wled`

Open FloEdelmann opened this issue 8 months ago • 5 comments

  • Update manufacturers.json
  • Add fixture aircookie/wled

Thank you @mxklb!

FloEdelmann avatar Apr 19 '25 14:04 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ aircookie / wled: d-light / attributes-correctness
  • ✔️ aircookie/wled-rgb.xml
  • ✔️ aircookie/wled-drgb.xml
  • ✔️ aircookie/wled-effect.xml
  • ✔️ aircookie/wled-effwht.xml
  • ✔️ aircookie/wled-preset.xml
✔️ aircookie / wled: dmxcontrol3 / channel-numbers
  • ✔️ aircookie-wled-rgb.xml
  • ✔️ aircookie-wled-drgb.xml
  • ✔️ aircookie-wled-effect.xml
  • ✔️ aircookie-wled-effwht.xml
  • ✔️ aircookie-wled-preset.xml
✔️ aircookie / wled: dragonframe / json-schema-conformity
  • ✔️ aircookie/wled.json
  • ✔️ manufacturers.json
✔️ aircookie / wled: millumin / json-schema-conformity
  • ✔️ aircookie/wled.json
aircookie / wled: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Aircookie-WLED.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
aircookie / wled: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Aircookie-WLED.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

github-actions[bot] avatar Apr 19 '25 14:04 github-actions[bot]

How to push changes to this branch? I have some macro edits, that are not efficient in Webinterface. wled.json I am not allowed to push these changes, please adopt wled.json to correctely add macro channels

mxklb avatar Apr 19 '25 15:04 mxklb

@mxklb There are a couple of options:

  1. create an additional pull request to this branch (branch2025-04-19T14-09-31) which we can merge into this one.
  2. copy the contents of this pull request into a new branch along with your desired changes, create a new pull request and then we can close this one.

luc122c avatar Apr 21 '25 20:04 luc122c

All right, thank you, here we go: https://github.com/OpenLightingProject/open-fixture-library/pull/4813

mxklb avatar Apr 22 '25 16:04 mxklb

#4813 is now ready and can be merged into this PR here

mxklb avatar Apr 30 '25 13:04 mxklb