open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `martin/viper-xip`

Open FloEdelmann opened this issue 8 months ago • 3 comments

  • Add fixture martin/viper-xip

Fixture warnings / errors

  • martin/viper-xip
    • ❌ File does not match schema: fixture/availableChannels/No function must NOT be valid
    • ❌ File does not match schema: fixture/availableChannels/No function must match "then" schema
    • ❌ File does not match schema: fixture/availableChannels/No function 7 must NOT be valid
    • ❌ File does not match schema: fixture/availableChannels/No function 7 must match "then" schema
    • ❌ File does not match schema: fixture/availableChannels/No function 10 must NOT be valid
    • ❌ File does not match schema: fixture/availableChannels/No function 10 must match "then" schema

Thank you Argo!

FloEdelmann avatar Apr 15 '25 12:04 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ martin / viper-xip: d-light / attributes-correctness
  • ✔️ martin/viper-xip-Basic.xml
martin / viper-xip: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Exporting fixture mode martin/viper-xip/Basic failed: TypeError: Cannot read properties of null (reading 'type')
martin / viper-xip: dragonframe / json-schema-conformity
  • ❌ martin/viper-xip.jsonfixture/availableChannels/No function must NOT be valid
  • ✔️ manufacturers.json
martin / viper-xip: millumin / json-schema-conformity
  • ❌ martin/viper-xip.jsonfixture/availableChannels/No function (type: Nothing) must NOT have more than 1 properties
    fixture/availableChannels/No function (type: Nothing) must have required property 'name'
    fixture/availableChannels/No function (type: Nothing) must match exactly one schema in oneOf
martin / viper-xip: qlcplus_4.12.2 / fixture-tool-validation
  • Unable to export fixture: Exporting fixture martin/viper-xip failed: TypeError: Cannot read properties of null (reading 'type')
martin / viper-xip: qlcplus_4.12.2 / xsd-schema-conformity
  • Unable to export fixture: Exporting fixture martin/viper-xip failed: TypeError: Cannot read properties of null (reading 'type')

github-actions[bot] avatar Apr 15 '25 12:04 github-actions[bot]

Hello. Can anyone help me fix the Martin Viper Xip fixture?

Valdmaaargo avatar Apr 15 '25 13:04 Valdmaaargo

Hello. Can anyone help me fix the Martin Viper Xip fixture?

This is a pretty complex fixture to start with. Do you have any specific questions?

General suggestions:

  • remove "defaultValue" (it doesn't work like you think it does here)
  • add the other modes (OFL requires all modes)
  • try converting the NoFunction channels into their respective features (this is a fairly standard if complex fixture, so OFL should support most/all of them)
  • read about template channels, or look at how they're used in other similar fixtures

What you've got so far looks like a great start.

kengruven avatar Apr 17 '25 16:04 kengruven