open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add 2 new fixtures

Open FloEdelmann opened this issue 8 months ago • 2 comments

  • Add fixture varytec/hero-wash-340fx-rgbw-zoom-8ch-mode
  • Add fixture varytec/hero-wash-340fx-rgbw-zoom-16ch-mode

Fixture warnings / errors

  • varytec/hero-wash-340fx-rgbw-zoom-8ch-mode
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/1 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/2 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/3 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/4 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Zoom/capability (type: Zoom) must have required property 'angle'
    • ❌ File does not match schema: fixture/availableChannels/Zoom/capability (type: Zoom) must have required property 'angleStart'
    • ❌ File does not match schema: fixture/availableChannels/Zoom/capability (type: Zoom) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Beam Split Effect/capabilities/2 (type: Rotation) must NOT have additional properties (effectName)
    • ❌ File does not match schema: fixture/availableChannels/Beam Split Effect/capabilities/3 (type: Rotation) must NOT have additional properties (effectName)
    • ❌ File does not match schema: fixture/availableChannels/Auto Programs/capabilities/9 (type: SoundSensitivity) must have required property 'soundSensitivity'
    • ❌ File does not match schema: fixture/availableChannels/Auto Programs/capabilities/9 (type: SoundSensitivity) must have required property 'soundSensitivityStart'
    • ❌ File does not match schema: fixture/availableChannels/Auto Programs/capabilities/9 (type: SoundSensitivity) must match exactly one schema in oneOf
    • ⚠️ Please specify categories.
  • varytec/hero-wash-340fx-rgbw-zoom-16ch-mode
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/0 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/0 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/0 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/1 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/1 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/1 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/2 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/2 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/2 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/3 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/3 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/3 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/4 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/4 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/4 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/5 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/5 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/5 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/6 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/6 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/6 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/7 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/7 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/7 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/8 (type: ColorTemperature) must have required property 'colorTemperature'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/8 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    • ❌ File does not match schema: fixture/availableChannels/Color Temperature/capabilities/8 (type: ColorTemperature) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/1 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/2 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/3 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Color Macros/capabilities/4 (type: ColorPreset) must NOT have additional properties (color)
    • ❌ File does not match schema: fixture/availableChannels/Zoom/capability (type: Zoom) must have required property 'angle'
    • ❌ File does not match schema: fixture/availableChannels/Zoom/capability (type: Zoom) must have required property 'angleStart'
    • ❌ File does not match schema: fixture/availableChannels/Zoom/capability (type: Zoom) must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Beam Split Effect/capabilities/2 (type: Rotation) must NOT have additional properties (effectName)
    • ❌ File does not match schema: fixture/availableChannels/Beam Split Effect/capabilities/3 (type: Rotation) must NOT have additional properties (effectName)
    • ❌ File does not match schema: fixture/availableChannels/Auto Programs/capabilities/9 (type: SoundSensitivity) must have required property 'soundSensitivity'
    • ❌ File does not match schema: fixture/availableChannels/Auto Programs/capabilities/9 (type: SoundSensitivity) must have required property 'soundSensitivityStart'
    • ❌ File does not match schema: fixture/availableChannels/Auto Programs/capabilities/9 (type: SoundSensitivity) must match exactly one schema in oneOf
    • ⚠️ Please specify categories.

Thank you Strand!

FloEdelmann avatar Apr 02 '25 10:04 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

varytec / hero-wash-340fx-rgbw-zoom-16ch-mode: d-light / attributes-correctness
  • Unable to export fixture: Exporting fixture mode varytec/hero-wash-340fx-rgbw-zoom-16ch-mode/16ch failed: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
varytec / hero-wash-340fx-rgbw-zoom-16ch-mode: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Exporting fixture mode varytec/hero-wash-340fx-rgbw-zoom-16ch-mode/16ch failed: TypeError: Cannot read properties of null (reading '0')
varytec / hero-wash-340fx-rgbw-zoom-16ch-mode: dragonframe / json-schema-conformity
  • ❌ varytec/hero-wash-340fx-rgbw-zoom-16ch-mode.jsonfixture/availableChannels/Color Temperature/capabilities/0 (type: ColorTemperature) must have required property 'colorTemperature'
    fixture/availableChannels/Color Temperature/capabilities/0 (type: ColorTemperature) must have required property 'colorTemperatureStart'
    fixture/availableChannels/Color Temperature/capabilities/0 (type: ColorTemperature) must match exactly one schema in oneOf
  • ✔️ manufacturers.json
varytec / hero-wash-340fx-rgbw-zoom-16ch-mode: millumin / json-schema-conformity
  • Unable to export fixture: Exporting fixture varytec/hero-wash-340fx-rgbw-zoom-16ch-mode failed: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
varytec / hero-wash-340fx-rgbw-zoom-16ch-mode: qlcplus_4.12.2 / fixture-tool-validation
  • Unable to export fixture: Exporting fixture varytec/hero-wash-340fx-rgbw-zoom-16ch-mode failed: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
varytec / hero-wash-340fx-rgbw-zoom-16ch-mode: qlcplus_4.12.2 / xsd-schema-conformity
  • Unable to export fixture: Exporting fixture varytec/hero-wash-340fx-rgbw-zoom-16ch-mode failed: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
varytec / hero-wash-340fx-rgbw-zoom-8ch-mode: d-light / attributes-correctness
  • Unable to export fixture: Exporting fixture mode varytec/hero-wash-340fx-rgbw-zoom-8ch-mode/8ch failed: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
varytec / hero-wash-340fx-rgbw-zoom-8ch-mode: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Exporting fixture mode varytec/hero-wash-340fx-rgbw-zoom-8ch-mode/8ch failed: TypeError: Cannot read properties of null (reading '0')
varytec / hero-wash-340fx-rgbw-zoom-8ch-mode: dragonframe / json-schema-conformity
  • ❌ varytec/hero-wash-340fx-rgbw-zoom-8ch-mode.jsonfixture/availableChannels/Color Macros/capabilities/1 (type: ColorPreset) must NOT have additional properties (color)
  • ✔️ manufacturers.json
varytec / hero-wash-340fx-rgbw-zoom-8ch-mode: millumin / json-schema-conformity
  • Unable to export fixture: Exporting fixture varytec/hero-wash-340fx-rgbw-zoom-8ch-mode failed: TypeError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
varytec / hero-wash-340fx-rgbw-zoom-8ch-mode: qlcplus_4.12.2 / fixture-tool-validation
  • Unable to export fixture: Exporting fixture varytec/hero-wash-340fx-rgbw-zoom-8ch-mode failed: TypeError: Cannot read properties of null (reading '0')
varytec / hero-wash-340fx-rgbw-zoom-8ch-mode: qlcplus_4.12.2 / xsd-schema-conformity
  • Unable to export fixture: Exporting fixture varytec/hero-wash-340fx-rgbw-zoom-8ch-mode failed: TypeError: Cannot read properties of null (reading '0')

github-actions[bot] avatar Apr 02 '25 10:04 github-actions[bot]

I compared these to varytec/hero-wash-340fx-rgbw-zoom.json, and it looks worse in many ways. Two fixtures (versus one fixture with two modes), lots of data in "comment" or "Generic" (versus structured data), etc.

The only way I see this improves the existing one is that it has hex values for 4 of the color presets (red, green, blue, white), so we could grab those 4 lines, but otherwise I don't think this is worth keeping.

kengruven avatar Apr 16 '25 22:04 kengruven