open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `sdj/ledkit7`

Open FloEdelmann opened this issue 1 year ago • 1 comments

  • Update manufacturers.json
  • Add fixture sdj/ledkit7

Fixture warnings / errors

  • sdj/ledkit7
    • ❌ File does not match schema: fixture/physical/DMXconnector "3-pin IP65" must be equal to one of [3-pin, 3-pin (swapped +/-), 3-pin XLR IP65, 5-pin, 5-pin XLR IP65, 3-pin and 5-pin, 3.5mm stereo jack, RJ45]
    • ⚠️ Please check if manufacturer is correct and add manufacturer URL.

User comment

sdj ledkit7

Thank you furio!

FloEdelmann avatar Jul 31 '24 17:07 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ sdj / ledkit7: d-light / attributes-correctness
  • ✔️ sdj/ledkit7-ok.xml
✔️ sdj / ledkit7: dmxcontrol3 / channel-numbers
  • ✔️ sdj-ledkit7-ok.xml
sdj / ledkit7: dragonframe / json-schema-conformity
  • ❌ sdj/ledkit7.jsonfixture/physical/DMXconnector "3-pin IP65" must be equal to one of [3-pin, 3-pin (swapped +/-), 3-pin XLR IP65, 5-pin, 5-pin XLR IP65, 3-pin and 5-pin, 3.5mm stereo jack]
  • ✔️ manufacturers.json
sdj / ledkit7: millumin / json-schema-conformity
  • ❌ sdj/ledkit7.jsonfixture/physical/DMXconnector "3-pin IP65" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]
sdj / ledkit7: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/sdj-ledkit7.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
sdj / ledkit7: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/sdj-ledkit7.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

github-actions[bot] avatar Jul 31 '24 17:07 github-actions[bot]

This looks like this fixture. The PDF there shows 7 different modes, and none of them matches the one given here.

If I were going to work on this, I'd probably find it easier to start with one of the other Stand fixtures already in OFL. This mapping isn't complete, and what's here doesn't look correct.

kengruven avatar Nov 06 '24 02:11 kengruven