open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head`

Open FloEdelmann opened this issue 1 year ago • 6 comments

  • Add fixture lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head

Fixture warnings / errors

  • lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head
    • ❌ Capability 'Wheel slot rotation stop' (0…127) in channel 'Gobo Stencil Rotation' does not explicitly reference any wheel, but the default wheel 'Gobo Stencil Rotation' (through the channel name) does not exist.
    • ❌ Capability 'Wheel slot rotation CW slow…fast' (128…191) in channel 'Gobo Stencil Rotation' does not explicitly reference any wheel, but the default wheel 'Gobo Stencil Rotation' (through the channel name) does not exist.
    • ❌ Capability 'Wheel slot rotation CCW slow…fast' (192…255) in channel 'Gobo Stencil Rotation' does not explicitly reference any wheel, but the default wheel 'Gobo Stencil Rotation' (through the channel name) does not exist.

Thank you @adiac!

FloEdelmann avatar May 30 '24 14:05 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: d-light / attributes-correctness
  • ✔️ lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head-11ch.xml
lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Exporting fixture mode lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head/11ch failed: TypeError: Cannot read properties of null (reading 'type')
✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: dragonframe / json-schema-conformity
  • ✔️ lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head.json
  • ✔️ manufacturers.json
✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: millumin / json-schema-conformity
  • ✔️ lightmaxx/platinum-line-mini-exeo-led-25w-led-moving-head.json
lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/lightmaXX-Platinum-Line-MINI-EXEO-LED-25W-LED-Moving-Head.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:Color Wheel/Dark Red/Res1: FX color Dark Red (#ff0000) should have color code #8b0000, the name for given FX color code is Red ./manufacturer/fixture.qxf: Invalid PAN degrees ./manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 3 errors detected
✔️ lightmaxx / platinum-line-mini-exeo-led-25w-led-moving-head: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/lightmaXX-Platinum-Line-MINI-EXEO-LED-25W-LED-Moving-Head.qxf

github-actions[bot] avatar May 30 '24 14:05 github-actions[bot]

I already contacted the manufacturer for a manual and will update you if I hear back from them. I used the 13ch-var manual and tested everything with the fixture myself.

adiac avatar May 30 '24 14:05 adiac

@adiac, just curious, what software do you use to test OFL fixtures?

kengruven avatar May 30 '24 15:05 kengruven

@kengruven, I use QLC+ 4. Which is a good software, but still gives me a lot of headache. ^^

But with testing I meant, that I just checked if the values of this manual correspond with what the fixture is actually doing.

adiac avatar May 30 '24 15:05 adiac

@kengruven can this be merged or not? I would like to use the fixture definition in my program very soon.

adiac avatar Jul 10 '24 19:07 adiac

I said from the start that I was fine with this, but I'm not an OFL maintainer.

(Regardless of whether it's merged, though, if you want control of your fixture definitions, I think your best bet is to use your own fork, not rely on the head of someone else's repo.)

kengruven avatar Jul 11 '24 03:07 kengruven