Add fixture `american-dj/encore-lp5ip`

Open FloEdelmann opened this issue 1 year ago • 2 comments

Add fixture american-dj/encore-lp5ip

Thank you @HickmanLighting!

Apr 21 '24 05:04 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ american-dj / encore-lp5ip: d-light / attributes-correctness

✔️ american-dj/encore-lp5ip-10ch.xml

✔️ american-dj / encore-lp5ip: dmxcontrol3 / channel-numbers

✔️ american-dj-encore-lp5ip-10ch.xml

✔️ american-dj / encore-lp5ip: dragonframe / json-schema-conformity

✔️ american-dj/encore-lp5ip.json
✔️ manufacturers.json

❌ american-dj / encore-lp5ip: millumin / json-schema-conformity

❌ american-dj/encore-lp5ip.json
fixture/physical/DMXconnector "5-pin XLR IP65" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]

✔️ american-dj / encore-lp5ip: qlcplus_4.12.2 / fixture-tool-validation

✔️ fixtures/American-DJ-Encore-LP5IP.qxf

❌ american-dj / encore-lp5ip: qlcplus_4.12.2 / xsd-schema-conformity

❌ fixtures/American-DJ-Encore-LP5IP.qxf
Element '{http://www.qlcplus.org/FixtureDefinition}Technical', attribute 'DmxConnector': [facet 'enumeration'] The value '5-pin XLR IP65' is not an element of the set {'3-pin', '5-pin', '3-pin and 5-pin', '3-pin IP65', '5-pin IP65', '3.5 mm stereo jack', 'Wireless', 'Other'}.

Apr 21 '24 05:04 github-actions[bot]

Yes… first fixture to write… thanks for the suggestions

Robert Hickman @.*** 615.807.0159

On Wed, Apr 24, 2024 at 9:01 PM Ken Harris @.***> wrote:

@.**** commented on this pull request.

This one looked good as far as it went but it turns out it was missing quite a lot. Let me know if these changes look OK.

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578522710 :

"shortName": "EnLP5IP",

"categories": ["Color Changer"],
"meta": {
"authors": ["HickmanLighting"],
"createDate": "2024-04-21",
"lastModifyDate": "2024-04-21"
},
"links": {
"manual": [

 "https://d295jznhem2tn9.cloudfront.net/ItemRelatedFiles/13355/ADJ%20ENCORE%20LP5IP%20-%20USER%20MANUAL.pdf"

],
"productPage": [
```
 "https://www.adj.com/encore-lp5ip"
```
],
"video": [

 "https://www.youtube.com/watch?v=1B8vrShd7zw&t=1s"

⬇️ Suggested change

 "https://www.youtube.com/watch?v=1B8vrShd7zw&t=1s"

 "https://www.youtube.com/watch?v=1B8vrShd7zw"

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578525789 :

```
     "type": "ShutterStrobe",
```

```
     "shutterEffect": "Open"
```
```
   }
```
```
 ]
```
},
"Dimmer": {

 "fineChannelAliases": ["Dimmer fine"],

```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "Intensity"
```
```
 }
```
}
},
"modes": [
{
```
 "name": "10ch",
```

⬇️ Suggested change

```
 "name": "10ch",
```

```
 "name": "10-channel",
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578527950 :

```
     "colorTemperatureStart": "2700K",
```

```
     "colorTemperatureEnd": "2700K"
```

⬇️ Suggested change

```
     "colorTemperatureStart": "2700K",
```
```
     "colorTemperatureEnd": "2700K"
```

```
     "colorTemperature": "2700K"
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578528489 :

```
     "colorTemperatureStart": "3200K",
```

```
     "colorTemperatureEnd": "3200K"
```

⬇️ Suggested change

```
     "colorTemperatureStart": "3200K",
```
```
     "colorTemperatureEnd": "3200K"
```

```
     "colorTemperature": "3200K"
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578528812 :

```
     "colorTemperatureStart": "4000K",
```

```
     "colorTemperatureEnd": "4000K"
```

⬇️ Suggested change

```
     "colorTemperatureStart": "4000K",
```
```
     "colorTemperatureEnd": "4000K"
```

```
     "colorTemperature": "4000K"
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578528947 :

```
     "colorTemperatureStart": "5600K",
```

```
     "colorTemperatureEnd": "5600K"
```

⬇️ Suggested change

```
     "colorTemperatureStart": "5600K",
```
```
     "colorTemperatureEnd": "5600K"
```

```
     "colorTemperature": "5600K"
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578529129 :

```
     "colorTemperatureStart": "6500K",
```

```
     "colorTemperatureEnd": "6500K"
```

⬇️ Suggested change

```
     "colorTemperatureStart": "6500K",
```
```
     "colorTemperatureEnd": "6500K"
```

```
     "colorTemperature": "6500K"
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578531519 :

"dimensions": [150.6, 209, 255],

"weight": 2.4,
"power": 32,
"DMXconnector": "5-pin XLR IP65",
"bulb": {
```
 "type": "LED",
```
```
 "colorTemperature": 21188,
```
```
 "lumens": 607
```
},
"lens": {
```
 "degreesMinMax": [9.6, 9.6]
```
}
},
"availableChannels": {
"Red": {
```
 "highlightValue": "100%",
```

⬇️ Suggested change

```
 "highlightValue": "100%",
```

```
 "fineChannelAliases": ["Red fine"],
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578531902 :

```
 "lumens": 607
```

},
"lens": {
```
 "degreesMinMax": [9.6, 9.6]
```
}
},
"availableChannels": {
"Red": {
```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "ColorIntensity",
```
```
   "color": "Red"
```
```
 }
```
},
"Green": {
```
 "highlightValue": "100%",
```

⬇️ Suggested change

```
 "highlightValue": "100%",
```

```
 "fineChannelAliases": ["Green fine"],
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578532518 :

"Red": {

```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "ColorIntensity",
```
```
   "color": "Red"
```
```
 }
```
},
"Green": {
```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "ColorIntensity",
```
```
   "color": "Green"
```
```
 }
```
},
"Blue": {
```
 "highlightValue": "100%",
```

⬇️ Suggested change

```
 "highlightValue": "100%",
```

```
 "fineChannelAliases": ["Blue fine"],
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578532772 :

"Green": {

```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "ColorIntensity",
```
```
   "color": "Green"
```
```
 }
```
},
"Blue": {
```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "ColorIntensity",
```
```
   "color": "Blue"
```
```
 }
```
},
"Lime": {
```
 "highlightValue": "0%",
```

⬇️ Suggested change

```
 "highlightValue": "0%",
```

```
 "fineChannelAliases": ["Lime fine"],
```

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578567818 :

```
 "highlightValue": "0%",
```

```
 "capability": {
```
```
   "type": "ColorIntensity",
```
```
   "color": "Lime"
```
```
 }
```
},
"Color Macros": {
```
 "defaultValue": "0%",
```
```
 "capabilities": [
```
```
   {
```
```
     "dmxRange": [0, 0],
```
```
     "type": "NoFunction"
```
```
   },
```
```
   {
```
```
     "dmxRange": [1, 4],
```
```
     "type": "ColorPreset"
```

The manual has a table with every color, but until we support RGBL (#437 https://github.com/OpenLightingProject/open-fixture-library/issues/437), there's no direct way to encode most of them.

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578570359 :

```
     "dmxRange": [224, 255],
```

```
     "type": "ShutterStrobe",
```
```
     "shutterEffect": "Open"
```
```
   }
```
```
 ]
```
},
"Dimmer": {

 "fineChannelAliases": ["Dimmer fine"],

```
 "highlightValue": "100%",
```
```
 "capability": {
```
```
   "type": "Intensity"
```
```
 }
```
}
},
"modes": [
{

⬇️ Suggested change

{

{
```
 "name": "4-channel",
```
```
 "shortName": "4ch",
```
```
 "channels": [
```
```
   "Red",
```
```
   "Green",
```
```
   "Blue",
```
```
   "Lime"
```
```
 ]
```
},
{
```
 "name": "7-channel",
```
```
 "shortName": "7ch",
```
```
 "channels": [
```
```
   "Red",
```
```
   "Green",
```
```
   "Blue",
```
```
   "Lime",
```
```
   "Shutter / Strobe",
```
```
   "Dimmer",
```
```
   "Dimmer fine"
```
```
 ]
```
},
{
```
 "name": "8-channel",
```
```
 "shortName": "8ch",
```
```
 "channels": [
```
```
   "Red",
```
```
   "Red fine",
```
```
   "Green",
```
```
   "Green fine",
```
```
   "Blue",
```
```
   "Blue fine",
```
```
   "Lime",
```
```
   "Lime fine"
```
```
 ]
```
},
{

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578656106 :

```
   {
```

```
     "dmxRange": [192, 223],
```
```
     "type": "ShutterStrobe",
```
```
     "shutterEffect": "Strobe",
```
```
     "speedStart": "slow",
```
```
     "speedEnd": "fast",
```
```
     "randomTiming": true
```
```
   },
```
```
   {
```
```
     "dmxRange": [224, 255],
```
```
     "type": "ShutterStrobe",
```
```
     "shutterEffect": "Open"
```
```
   }
```
```
 ]
```
},
"Dimmer": {

⬇️ Suggested change

"Dimmer": {

"Auto Programs": {
```
 "capabilities": [
```
```
   {
```
```
     "dmxRange": [0, 31],
```
```
     "type": "NoFunction"
```
```
   },
```
```
   {
```
```
     "dmxRange": [32, 63],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 1"
```
```
   },
```
```
   {
```
```
     "dmxRange": [64, 95],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 2"
```
```
   },
```
```
   {
```
```
     "dmxRange": [96, 127],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 3"
```
```
   },
```
```
   {
```
```
     "dmxRange": [128, 159],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 4"
```
```
   },
```
```
   {
```
```
     "dmxRange": [160, 191],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 5"
```
```
   },
```
```
   {
```
```
     "dmxRange": [192, 223],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 6"
```
```
   },
```
```
   {
```
```
     "dmxRange": [224, 255],
```
```
     "type": "Effect",
```
```
     "effectName": "Auto Program 7"
```
```
   }
```
```
 ]
```
},
"Auto Program Speed": {
```
 "capability": {
```
```
   "type": "EffectSpeed",
```
```
   "speedStart": "slow",
```
```
   "speedEnd": "fast"
```
```
 }
```
},
"Auto Program Fade": {
```
 "capability": {
```
```
   "type": "EffectDuration",
```
```
   "durationStart": "short",
```
```
   "durationEnd": "long"
```
```
 }
```
},
"Dim Curves": {
```
 "capabilities": [
```
```
   {
```
```
     "dmxRange": [0, 20],
```
```
     "type": "Maintenance",
```
```
     "comment": "Square"
```
```
   },
```
```
   {
```
```
     "dmxRange": [21, 40],
```
```
     "type": "Maintenance",
```
```
     "comment": "Linear"
```
```
   },
```
```
   {
```
```
     "dmxRange": [41, 60],
```
```
     "type": "Maintenance",
```
```
     "comment": "Inv. square"
```
```
   },
```
```
   {
```
```
     "dmxRange": [61, 80],
```
```
     "type": "Maintenance",
```
```
     "comment": "S. Curve"
```
```
   },
```
```
   {
```
```
     "dmxRange": [381, 255],
```
```
     "type": "NoFunction"
```
```
   }
```
```
 ]
```
},
"Special Functions": {
```
 "capabilities": [
```
```
   {
```
```
     "dmxRange": [0, 15],
```
```
     "type": "Maintenance",
```

     "comment": "Default to Unit Setting"

```
   },
```
```
   {
```
```
     "dmxRange": [16, 30],
```
```
     "type": "Maintenance",
```

     "comment": "900 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [31, 45],
```
```
     "type": "Maintenance",
```

     "comment": "1000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [46, 60],
```
```
     "type": "Maintenance",
```

     "comment": "1100 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [61, 75],
```
```
     "type": "Maintenance",
```

     "comment": "1200 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [76, 90],
```
```
     "type": "Maintenance",
```

     "comment": "1300 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [91, 105],
```
```
     "type": "Maintenance",
```

     "comment": "1400 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [106, 120],
```
```
     "type": "Maintenance",
```

     "comment": "1500 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [121, 135],
```
```
     "type": "Maintenance",
```

     "comment": "2500 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [136, 150],
```
```
     "type": "Maintenance",
```

     "comment": "4000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [151, 165],
```
```
     "type": "Maintenance",
```

     "comment": "5000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [166, 180],
```
```
     "type": "Maintenance",
```

     "comment": "10000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [181, 195],
```
```
     "type": "Maintenance",
```

     "comment": "15000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [196, 210],
```
```
     "type": "Maintenance",
```

     "comment": "20000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [211, 225],
```
```
     "type": "Maintenance",
```

     "comment": "25000 Hz LED refresh rate"

```
   },
```
```
   {
```
```
     "dmxRange": [226, 255],
```
```
     "type": "NoFunction"
```
```
   }
```
```
 ]
```
},
"Dimmer": {

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578672579 :

{

```
 "name": "10ch",
```
```
 "shortName": "10ch",
```
```
 "channels": [
```
```
   "Red",
```
```
   "Green",
```
```
   "Blue",
```
```
   "Lime",
```
```
   "Color Macros",
```
```
   "CTC",
```
```
   "Color Temperature Macros",
```
```
   "Shutter / Strobe",
```
```
   "Dimmer",
```
```
   "Dimmer fine"
```
```
 ]
```
}

⬇️ Suggested change

}

},
{
```
 "name": "13-channel",
```
```
 "shortName": "13ch",
```
```
 "channels": [
```
```
   "Red",
```
```
   "Green",
```
```
   "Blue",
```
```
   "Lime",
```
```
   "Color Macros",
```
```
   "CTC",
```
```
   "Color Temperature Macros",
```
```
   "Shutter / Strobe",
```
```
   "Dimmer",
```
```
   "Dimmer fine",
```
```
   "Dim Mode",
```
```
   "Dim Curves",
```
```
   "Special Functions"
```
```
 ]
```
},
{
```
 "name": "16-channel",
```
```
 "shortName": "16ch",
```
```
 "channels": [
```
```
   "Red",
```
```
   "Green",
```
```
   "Blue",
```
```
   "Lime",
```
```
   "Color Macros",
```
```
   "CTC",
```
```
   "Color Temperature Macros",
```
```
   "Shutter / Strobe",
```
```
   "Dimmer",
```
```
   "Dimmer fine",
```
```
   "Auto Programs",
```
```
   "Auto Program Speed",
```
```
   "Auto Program Fade",
```
```
   "Dim Mode",
```
```
   "Dim Curves",
```
```
   "Special Functions"
```
```
 ]
```
}

In fixtures/american-dj/encore-lp5ip.json https://github.com/OpenLightingProject/open-fixture-library/pull/3923#discussion_r1578755970 :

```
     "type": "ColorPreset"
```

```
   }
```
```
 ]
```
},
"CTC": {
```
 "capability": {
```
```
   "type": "ColorTemperature",
```
```
   "colorTemperatureStart": "2700K",
```
```
   "colorTemperatureEnd": "7000K"
```
```
 }
```
},
"Color Temperature Macros": {
```
 "capabilities": [
```
```
   {
```
```
     "dmxRange": [0, 0],
```
```
     "type": "NoFunction"
```

⬇️ Suggested change

```
     "type": "NoFunction"
```

```
     "type": "NoFunction",
```

     "helpWanted": "Is the CTC channel only active when this channel is 0?  Do we need switching?"

— Reply to this email directly, view it on GitHub https://github.com/OpenLightingProject/open-fixture-library/pull/3923#pullrequestreview-2020944427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR3MH46BIRSLWFL64X4BPCLY7BPXZAVCNFSM6AAAAABGRCUU2SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRQHE2DINBSG4 . You are receiving this because you were mentioned.Message ID: <OpenLightingProject/open-fixture-library/pull/3923/review/2020944427@ github.com>

May 14 '24 16:05 HickmanLighting