open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `stairville/par-36-56-64`

Open FloEdelmann opened this issue 2 years ago • 6 comments

  • Add fixture stairville/par-36-56-64

Fixture warnings / errors

  • stairville/par-36-56-64
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessStart 0 must be string
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessStart 0 must be string
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessStart 0 must be equal to one of [off, dark, bright]
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessStart 0 must match exactly one schema in oneOf
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessEnd 1 must be string
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessEnd 1 must be string
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessEnd 1 must be equal to one of [off, dark, bright]
    • :x: File does not match schema: fixture/availableChannels/Dim/capability/brightnessEnd 1 must match exactly one schema in oneOf
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedStart 0 must be string
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedStart 0 must be string
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedStart 0 must be string
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedStart 0 must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedStart 0 must match exactly one schema in oneOf
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedEnd 1 must be string
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedEnd 1 must be string
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedEnd 1 must be string
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedEnd 1 must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • :x: File does not match schema: fixture/availableChannels/Color Mix MSpeed/capability/speedEnd 1 must match exactly one schema in oneOf
    • :warning: Please add fixture categories.
    • :warning: Please add relevant links to the fixture.
    • :warning: Please add physical data to the fixture.

Thank you viki!

FloEdelmann avatar Dec 11 '23 19:12 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

:heavy_check_mark: stairville / par-36-56-64: d-light / attributes-correctness
  • :heavy_check_mark: stairville/par-36-56-64-Default.xml
:heavy_check_mark: stairville / par-36-56-64: dmxcontrol3 / channel-numbers
  • :heavy_check_mark: stairville-par-36-56-64-Default.xml
:x: stairville / par-36-56-64: dragonframe / json-schema-conformity
  • :x: stairville/par-36-56-64.jsonfixture/availableChannels/Dim/capability/brightnessStart 0 must be string
    fixture/availableChannels/Dim/capability/brightnessStart 0 must be string
    fixture/availableChannels/Dim/capability/brightnessStart 0 must be equal to one of [off, dark, bright]
    fixture/availableChannels/Dim/capability/brightnessStart 0 must match exactly one schema in oneOf
    fixture/availableChannels/Dim/capability (type: Intensity) must match "then" schema
  • :heavy_check_mark: manufacturers.json
:heavy_check_mark: stairville / par-36-56-64: millumin / json-schema-conformity
  • :heavy_check_mark: stairville/par-36-56-64.json
:x: stairville / par-36-56-64: qlcplus_4.12.2 / fixture-tool-validation
  • :x: fixtures/Stairville-Par-365664.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:Default: No physical data found 1 definitions processed. 1 errors detected
:heavy_check_mark: stairville / par-36-56-64: qlcplus_4.12.2 / xsd-schema-conformity
  • :heavy_check_mark: fixtures/Stairville-Par-365664.qxf

github-actions[bot] avatar Dec 11 '23 19:12 github-actions[bot]

Looks like https://images.thomann.de/pics/atg/atgdata/document/manual/c_193245_en_online.pdf

Dupe of existing fixture stairville/par-56?

kengruven avatar Dec 29 '23 16:12 kengruven

Strangely, the existing OFL fixture "PAR 56" links to a manual for the "PAR 56, PAR 64", which have a different DMX mapping (7 channel) than what's in OFL for that fixture (5 channel). This "PAR 36, PAR 56, PAR 64" is the 5-channel one.

So maybe we should change the existing OFL record to point to this user manual, and change its title to "PAR 36, PAR 56, PAR 64"? I'm not sure how to distinguish them except by listing part numbers -- you could in theory count if there's 49 or 50 green LEDs but I don't think anyone's going to do that.

kengruven avatar Jan 10 '24 17:01 kengruven

This is an older version of the hardware, from 2013, and can be identified externally from having a music/auto switch on the rear, which the newer version lacks. Additionally, I think this PR lacks detail on the function of channels 1 and 5, which can be found in the manual.

softrabbit avatar May 30 '24 13:05 softrabbit

This is an older version of the hardware, from 2013, and can be identified externally from having a music/auto switch on the rear, which the newer version lacks.

That's great info! Since Stairville doesn't seem to have unique product IDs, or even any branding on the fixture itself, we should put this fact in a top-level comment on both fixtures (or maybe even in the title?).

Additionally, I think this PR lacks detail on the function of channels 1 and 5, which can be found in the manual.

This is an automatic GDTF conversion, and I've been generally unimpressed with those, so I'm not surprised it's lacking. Do you happen to have a link to the manual for this version? Or do they have the same DMX map, and this mapping got the channels in the wrong order, too?

Stairville is certainly not making it easy on LX technicians.

kengruven avatar May 30 '24 14:05 kengruven

See #4002

softrabbit avatar May 31 '24 07:05 softrabbit