open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `fun-generation/led-pot-12x1w-qcl-rgb-ww-40`

Open FloEdelmann opened this issue 2 years ago • 1 comments

  • Update manufacturers.json
  • Add fixture thomann/fun-generation-led-pot-12x1w-qcl-rgb-ww-40

Fixture warnings / errors

  • thomann/fun-generation-led-pot-12x1w-qcl-rgb-ww-40
    • :x: File does not match schema: fixture/rdm/modelId "invalid" must be integer

Thank you Minno!

FloEdelmann avatar Oct 13 '23 10:10 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

:heavy_check_mark: thomann / fun-generation-led-pot-12x1w-qcl-rgb-ww-40: d-light / attributes-correctness
  • :heavy_check_mark: thomann/fun-generation-led-pot-12x1w-qcl-rgb-ww-40-6c.xml
:heavy_check_mark: thomann / fun-generation-led-pot-12x1w-qcl-rgb-ww-40: dmxcontrol3 / channel-numbers
  • :heavy_check_mark: thomann-fun-generation-led-pot-12x1w-qcl-rgb-ww-40-6c.xml
:x: thomann / fun-generation-led-pot-12x1w-qcl-rgb-ww-40: dragonframe / json-schema-conformity
  • :x: thomann/fun-generation-led-pot-12x1w-qcl-rgb-ww-40.jsonfixture/rdm/modelId "invalid" must be integer
  • :heavy_check_mark: manufacturers.json
:x: thomann / fun-generation-led-pot-12x1w-qcl-rgb-ww-40: millumin / json-schema-conformity
  • :x: thomann/fun-generation-led-pot-12x1w-qcl-rgb-ww-40.jsonfixture/rdm/modelId "invalid" must be integer
:x: thomann / fun-generation-led-pot-12x1w-qcl-rgb-ww-40: qlcplus_4.12.2 / fixture-tool-validation
  • :x: fixtures/Thomann-Fun-Generation-LED-Pot-12x1W-QCL-RGB-WW-40°.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:6 Channel: No physical data found 1 definitions processed. 1 errors detected
:heavy_check_mark: thomann / fun-generation-led-pot-12x1w-qcl-rgb-ww-40: qlcplus_4.12.2 / xsd-schema-conformity
  • :heavy_check_mark: fixtures/Thomann-Fun-Generation-LED-Pot-12x1W-QCL-RGB-WW-40°.qxf

github-actions[bot] avatar Oct 13 '23 10:10 github-actions[bot]

@FloEdelmann Do you mind if I fix this PR?

p-rogalski avatar Sep 09 '24 17:09 p-rogalski

@p-rogalski Thanks for opening a separate PR with the fixes! I'll close this one then.

FloEdelmann avatar Sep 10 '24 10:09 FloEdelmann