open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `cameo/zenith-z120-g2`

Open FloEdelmann opened this issue 2 years ago • 1 comments

  • Add fixture cameo/zenith-z120-g2

Fixture warnings / errors

  • cameo/zenith-z120-g2
    • :x: File does not match schema: fixture/physical/dimensions/0 "invalid" must be number
    • :x: File does not match schema: fixture/physical/dimensions/1 "invalid" must be number
    • :x: File does not match schema: fixture/physical/weight "invalid" must be number

Thank you Jérôme!

FloEdelmann avatar Sep 29 '23 14:09 FloEdelmann

There's 3 closely related PRs here:

  • #1303 is for the Z120, and it's mostly good
  • #2258 is for the Z120 G2, which is almost identical to the Z120 except for some changes to the "Settings" channel -- but that PR doesn't have any of the updated Settings mapped
  • #3484 (this one) is also for the Z120 G2, and it maps some of the new Settings, but not correctly, I think

My suggestion:

  • clean up #1303 and merge it -- it's almost there
  • close #2258 -- it doesn't really have anything useful
  • copy "cameo/zenit-z120.json" to "cameo/zenit-z120-g2.json", and update the URLs, and the Settings channel

kengruven avatar Dec 26 '23 20:12 kengruven