open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture 'algam/barwash-36'

Open FloEdelmann opened this issue 3 years ago • 2 comments

  • Update manufacturers.json
  • Add fixture 'algam/barwash-36'

Fixture warnings / errors

  • algam/barwash-36
    • :x: File does not match schema: fixture/physical/weight "invalid" must be number

Thank you Paolo M!

FloEdelmann avatar Mar 29 '22 12:03 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

:heavy_check_mark: algam / barwash-36: d-light / attributes-correctness
  • :heavy_check_mark: algam/barwash-36-3.xml
  • :heavy_check_mark: algam/barwash-36-5.xml
  • :heavy_check_mark: algam/barwash-36-13.xml
:heavy_check_mark: algam / barwash-36: dmxcontrol3 / channel-numbers
  • :heavy_check_mark: algam-barwash-36-3.xml
  • :heavy_check_mark: algam-barwash-36-5.xml
  • :heavy_check_mark: algam-barwash-36-13.xml
:x: algam / barwash-36: dragonframe / json-schema-conformity
  • :x: algam/barwash-36.jsonfixture/physical/weight "invalid" must be number
  • :heavy_check_mark: manufacturers.json
:x: algam / barwash-36: millumin / json-schema-conformity
  • :x: algam/barwash-36.jsonfixture/physical/weight "invalid" must be number
:heavy_check_mark: algam / barwash-36: qlcplus_4.12.2 / fixture-tool-validation
  • :heavy_check_mark: fixtures/Algam-Barwash-36.qxf
:x: algam / barwash-36: qlcplus_4.12.2 / xsd-schema-conformity
  • :x: fixtures/Algam-Barwash-36.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': 'invalid' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.

github-actions[bot] avatar Mar 29 '22 12:03 github-actions[bot]

This looks like a great start, and it'd be usable right now, but there are some improvements which can be made.

  • The product URL here looks like a retailer. I'd say the actual product URL is: https://www.algam-entreprises.com/?action=showProduitAE&idProduit=549903

  • Likewise, the company webpage might be https://www.algam-entreprises.com/ or even https://www.algam-entreprises.com/marques/ALGAM-LIGHTING-ALGLIG/

  • I think "All color" here is actually an overall Intensity, not White (since they're only RGB).

  • There are several "parameterStart": "off", "parameterEnd": "off" lines which don't seem to do anything and can probably be deleted.

  • I don't see anything that indicates "Sound-Active mode" has DMX-controlled sound sensitivity levels across those 5 values, but maybe that's the case.

  • Beam angle is 42°. Weight is 2.8 kg.

  • "Stroboscopies" sounds like a French word? -- in English, the channel is just called "Strobe".

  • Do "Pixel Bar" type fixtures use the OFL "matrix" feature? I think "Red"/"Red 2"/"Red 3" is probably not the ideal way to encode this.

kengruven avatar Apr 01 '22 13:04 kengruven