open-fixture-library icon indicating copy to clipboard operation
open-fixture-library copied to clipboard

Add fixture `stairville/led-vintage-bowl-50-rgba`

Open FloEdelmann opened this issue 4 years ago • 4 comments

  • Add fixture 'stairville/led-vintage-bowl-50-rgba'

Thank you olivier marzullo!

FloEdelmann avatar Feb 01 '21 14:02 FloEdelmann

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests. You can run a plugin's export tests by executing: $ node cli/run-export-test.js -p <plugin name> <fixtures>

:heavy_check_mark: stairville / led-vintage-bowl-50-rgba: d-light / attributes-correctness
  • :heavy_check_mark: stairville/led-vintage-bowl-50-rgba-intensity Red.xml
:heavy_check_mark: stairville / led-vintage-bowl-50-rgba: dragonframe / json-schema-conformity
  • :heavy_check_mark: stairville/led-vintage-bowl-50-rgba.json
  • :heavy_check_mark: manufacturers.json
:heavy_check_mark: stairville / led-vintage-bowl-50-rgba: millumin / json-schema-conformity
  • :heavy_check_mark: stairville/led-vintage-bowl-50-rgba.json
:x: stairville / led-vintage-bowl-50-rgba: qlcplus_4.12.2 / fixture-tool-validation
  • :x: fixtures/Stairville-led-vintage-bowl-50-RGBA.qxfNamespace(convert=None, map=False, validate=['.']) manufacturer/fixture.qxf: Invalid physical dimensions detected manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 2 errors detected
:x: stairville / led-vintage-bowl-50-rgba: qlcplus_4.12.2 / xsd-schema-conformity
  • :x: fixtures/Stairville-led-vintage-bowl-50-RGBA.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': '0' is not a valid value of the atomic type '{http://www.qlcplus.org/FixtureDefinition}weightType'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

github-actions[bot] avatar Feb 01 '21 14:02 github-actions[bot]

Let's close this one. #1451 is the Vintage Bowl 30, which is the same as the Vintage Bowl 50 except for size (and has the same DMX mapping, and even the same manual). #1451 isn't perfect, but it's a lot further along than #1712.

kengruven avatar Dec 26 '23 04:12 kengruven

@FloEdelmann if the two fixtures have the same mapping, would this be a good use case for a fixture redirect?

luc122c avatar Dec 26 '23 12:12 luc122c

Another option?: I've noticed that "physical" is allowed under "modes", and some fixtures use this (though I haven't found any documentation for it). Can we duplicate just the mode name list, with alternative physical specifications, in the same OFL file?

kengruven avatar Dec 26 '23 16:12 kengruven