ola icon indicating copy to clipboard operation
ola copied to clipboard

Make device/port naming consistent

Open peternewman opened this issue 10 years ago • 2 comments

It would be good to make device/port names internally consistent. Currently only FadeCandy & JaRule follow my preference below, if we agree to it, we need to update the others.

I see three bits of info presented in the UI: Device Name Port Direction Port Description

Direction is defined by the port type, so we can ignore that. The ports are all a subset of the device.

My test install currently lists the following (IPs obscured): E1.31 (DMX over ACN) [127.0.0.1] Input

E1.31 (DMX over ACN) [127.0.0.1] Output

OSC Device Input /dmx/universe/%d OSC Device Input /dmx/universe/%d OSC Device Input /dmx/universe/%d OSC Device Output 127.0.0.1:7770/4/multifader1,

As I see it, the E1.31 device is the way to go, the IP is common across all ports, so it's listed at the device level, the ports don't actually have a description.

Consider the following: Nodle 1 <1234> Input Nodle 1 <1234> Output Nodle 1 <5678> Input Nodle 1 <5678> Output

I think that's more correct than: Nodle 1 Input <1234> Nodle 1 Output <1234> Nodle 1 Input <5678> Nodle 1 Output <5678>

Especially when we get onto the next level, say a two port Nodle, or the Enttec Pro Mk 2, this feels like the right way to go: Nodle 1 <1234> Input Port 1 Nodle 1 <1234> Input Port 2 Nodle 1 <1234> Output Port 1 Nodle 1 <1234> Output Port 2 Nodle 1 <5678> Input Port 1 Nodle 1 <5678> Input Port 2 Nodle 1 <5678> Output Port 1 Nodle 1 <5678> Output Port 2

Plus if we rewrote the UI, or someone write another UI using a tree or a wizard or whatever, you pick the device "Nodle 1 <1234>" with serial 1234, then you can pick a port (or a specific class of port in/out) from the list to patch to it.

peternewman avatar Nov 14 '15 16:11 peternewman

@StefanKrupop do you fancy doing this for the Nodle code? Or would you at least be willing to test it if I do it?

peternewman avatar Nov 14 '15 23:11 peternewman

@nomis52 is happy with this if he doesn't have to do the leg work :)

peternewman avatar Nov 15 '15 12:11 peternewman