E1.33 controller
I realised you might not have got the @mention in my personal repo ( https://github.com/peternewman/ola/pull/43 ) so I'll stick it here too.
This PR would want to go in after #1612 as it's done on top of that.
Please don't actually start reviewing this @kripton , but if you fancy taking a look at it in due course, I was going to break it down a bit to reduce the overall changes of this and https://github.com/OpenLightingProject/ola/pull/1612/files .
Most of the commits add a new PDU each (across three files), do you think there's an optimal number of files/size of commit to split it into for review?
I'll need to cherry-pick to get them into master without just queuing them up behind the existing LLRP stuff, but they should work fine standalone functionally...
Still todo:
- [ ] Ensure we catch vectors with the wrong value in tests - https://github.com/OpenLightingProject/ola/pull/1939#discussion_r1513472158
- [ ] Fix any todos (particularly test related)
- [ ] Remove duplication of ACN header between libs/acn/TCPTransport.cpp and libs/acn/PreamblePacker.cpp
- [ ] Remove all the redundant pre-standardised E1.33 stuff (e.g. DeviceManager)?
- [ ] Consider enum type cleanup - https://github.com/OpenLightingProject/ola/pull/1947#discussion_r1536678077
- [ ] Check for and fix any null pointer exceptions - https://github.com/OpenLightingProject/ola/pull/1950#discussion_r1545499176
- [ ] Consider inlining basic functions - https://github.com/OpenLightingProject/ola/pull/1957#discussion_r1563100815
- [ ] Rename E133Enums.h to E133Constants.h - https://github.com/OpenLightingProject/ola/pull/1957#discussion_r1563056859
Assigned to you @kripton just for thoughts on my questions at the top, please don't bother actually reviewing it yet as above...
Cherry-picked parts of it to #1939 for easier review and merging in small chunks
I've not fully committed and pushed, but I've just finally got the basics of an OLAd E1.33 plugin talking to the ETC RDMNet implementation and even running the RDM Responder Tests against it, so it would be great to get this in so others can start doing E1.33 testing too...