ci.maven icon indicating copy to clipboard operation
ci.maven copied to clipboard

dev mode help does not show option o

Open gkwan-ibm opened this issue 2 years ago • 3 comments

use LMP 3.7.1, start the dev mode, press h, will see following:

[INFO] ************************************************************************
[INFO] *        Automatic generation of features: [ Off ]
[INFO] *        g - toggle the automatic generation of features, type 'g' and press Enter.
[INFO] *            A new server configuration file will be generated in the SOURCE configDropins/overrides configuration directory.
[INFO] *        Enter - run tests on demand, press Enter.
[INFO] *        r - restart the server, type 'r' and press Enter.
[INFO] *        h - see the help menu for available actions, type 'h' and press Enter.
[INFO] *        q - stop the server and quit dev mode, press Ctrl-C or type 'q' and press Enter.
[INFO] ************************************************************************

Based on the doc at https://github.com/OpenLiberty/ci.maven/blob/main/docs/dev.md, there is an option o. Is it because that the option o is not released yet? If released, the help is missing that option. If not released, should hide it from the dev.md?

Also. several lines are longer than the top and bottom * lines. Should the content be wrapped/aligned?

gkwan-ibm avatar Nov 22 '22 16:11 gkwan-ibm

@gkwan-ibm the 'o' option will only be shown in the help menu if automatic generation of features is 'On'.

h
[INFO] ************************************************************************
[INFO] *        Automatic generation of features: [ On ]
[INFO] *        g - toggle the automatic generation of features, type 'g' and press Enter.
[INFO] *            A new server configuration file will be generated in the SOURCE configDropins/overrides configuration directory.
[INFO] *        o - optimize the list of generated features, type 'o' and press Enter.
[INFO] *            A new server configuration file will be generated in the SOURCE configDropins/overrides configuration directory.
[INFO] *        Enter - run tests on demand, press Enter.
[INFO] *        r - restart the server, type 'r' and press Enter.
[INFO] *        h - see the help menu for available actions, type 'h' and press Enter.
[INFO] *        q - stop the server and quit dev mode, press Ctrl-C or type 'q' and press Enter.
[INFO] ************************************************************************

If a user types 'o' while automatic generation of features is off, they will see the following warning:

o
[WARNING] Cannot optimize features because automatic generation of features is off.
[WARNING] To toggle the automatic generation of features, type 'g' and press Enter.

Also. several lines are longer than the top and bottom * lines. Should the content be wrapped/aligned?

+1 I agree that we should wrap/align better with the header and footer

kathrynkodama avatar Nov 22 '22 16:11 kathrynkodama

ok, I can see the option o. Thanks to let me know

gkwan-ibm avatar Nov 22 '22 16:11 gkwan-ibm

Also suggest an option to show the following information or h will include them:

[INFO] *    Liberty server port information:
[INFO] *        Liberty server HTTP port: [ 9081 ]
[INFO] *        Liberty debug port: [ 7777 ]

gkwan-ibm avatar Nov 22 '22 16:11 gkwan-ibm