ci.maven icon indicating copy to clipboard operation
ci.maven copied to clipboard

Java file change that fixes compilation error can trigger multiple feature generation calls

Open TrevCraw opened this issue 3 years ago • 0 comments

If multiple Java files are modified while there are compilation errors, once the compilation errors are resolved by a Java file change, there will be multiple feature generation calls. It appears that on Windows, the class file changes are being grouped together by package. Maybe this won't be an issue on Mac?

Find a way to only generate features once in this scenario.

Steps to reproduce:

  1. Use the demo devmode project
  2. Use mvn liberty:dev or gradle libertyDev to start up dev mode
  3. Add SystemLivenessCheck.java as the demo devmode instructions show
  4. Add a new package to src\main\java\io\openliberty\sample and create a new Java file in the new package
  5. Make a breaking change to SystemLivenessCheck.java - should be compilation error and no feature generation
  6. Make a working change to the new Java file - should still be compilation error and no feature generation
  7. Fix the breaking change in SystemLivenessCheck.java - compilation is successful and feature generation runs twice

Debug output: debug-output.txt

TrevCraw avatar May 06 '22 19:05 TrevCraw