ci.maven icon indicating copy to clipboard operation
ci.maven copied to clipboard

Refactor findAvailablePort() method

Open TrevCraw opened this issue 5 years ago • 3 comments

Combine the logic for Windows and other OS's inside of this method. Extract the code differences to other methods.

TrevCraw avatar Nov 19 '20 20:11 TrevCraw

This can probably be closed?

git grep findAvailablePort | wc -l
       0

bmarwell avatar Jan 20 '23 08:01 bmarwell

@TrevCraw was there anything interesting motivating the idea to refactor here or was it purely for code organization?

Nothing Maven vs. Gradle specific I assume.

I started looking for relevant issues since I noticed findAvailablePort not working as expected using Gradle and Windows 11... but in the past couple hours my problem went away. Blame the daemon cache I guess.

Thought I'd ask anyway.

scottkurz avatar Mar 10 '23 23:03 scottkurz

@scottkurz It is purely for code organization

TrevCraw avatar Mar 13 '23 21:03 TrevCraw