openleadr-python icon indicating copy to clipboard operation
openleadr-python copied to clipboard

Fixed problem with removing events during clean up

Open AryazE opened this issue 1 year ago • 2 comments

In the client's _event_cleanup popping items during iteration could cause missing events if two adjacent events in the list are to be removed. Iterating in reverse fixes this issue.

AryazE avatar Jun 05 '23 15:06 AryazE

Unfortunately, I could not add a test as I did not find any example setups for such a scenario and I am not very familiar with the framework to implement one myself.

AryazE avatar Jun 05 '23 15:06 AryazE

Thanks for the contribution and the fix! I'll check it out once I get to it and maybe write a test or two for it as well.

stan-janssen avatar Oct 18 '23 17:10 stan-janssen