openkore icon indicating copy to clipboard operation
openkore copied to clipboard

Autosell when overweight

Open piichia opened this issue 6 years ago • 7 comments

#2595 files fix...

this pull fixes #1526

piichia avatar Jan 25 '19 20:01 piichia

@piichia are you alive?

Nipodemos avatar Apr 13 '19 19:04 Nipodemos

Sorry for disappearing - haven't really had time to look into this lately but once the semester is over I'll get around to updating this in May.

piichia avatar Apr 15 '19 04:04 piichia

hello @piichia do you still want to fix this Pull Request?

Nipodemos avatar Nov 09 '19 19:11 Nipodemos

Incredibly sorry, life still is in the way. I haven't played the game in a year or so and due to the new eac stuff it's difficult for me to test any changes on the server I normally play. I'd like to fix it still, but that's kind of a big issue stopping me from trying anything at the moment.

piichia avatar Jun 18 '20 02:06 piichia

yes i understand that, i miss the time when i could test my code in official server 😭 so what you think, close this PR or not?

Nipodemos avatar Jun 18 '20 02:06 Nipodemos

Probably leave it open? If a public eac bypass isn't working within a year probably close it. Like that's got to be enough time for something or else it's likely it's a lost cause.

Up to you really 🤷‍♀️

piichia avatar Jun 18 '20 02:06 piichia

i don't mind leaving it open, if gets 2021 without eac bypass, we close it who knows what we will get until there

Nipodemos avatar Jun 18 '20 02:06 Nipodemos

This pull request is very old, and now have conflicts that must be resolved besides the code itself that needs to fix. Since is highly unlikely that the owner of the PR will fix due to the reasos cited a few comments up, and due to @LastRoze mentioning that it won't even work on newer servertype, i'm closing this pull request

Nipodemos avatar Mar 20 '23 18:03 Nipodemos