OpenKnowledgeMaps
CORE: Implement parameters from original specification
The CORE connector implements different parameters than the original specification. They were:
- from: publication date lower bound in the form YYYY-MM-DD
- to: publication date upper bound in the form YYYY-MM-DD
- article_types: in the form of an array of identifiers of article types
- langs: in the form of an array of language identifiers (["all"] for all languages)
- sorting: can be one of "most-relevant" and "most-recent"
From my point of view, there is no harm in keeping the additional parameters (the key param is even mandatory in the current implementation), but these five parameters should also be implemented to enable our usual query refinement options.
I'm currently working on this, but this requires a few additions to rcoreoa. I will open a PR with additional query params in rcoreoa soon.
The additional params 'repositoryDocument.metadataUpdated' and 'language.name' of the CORE elasticsearch API are documented here
It also appears that some functionalities will have to diverge from our current ones - CORE only provides article publication date with a yearly resolution. The parameter 'repositoryDocument.metadataUpdated' may be misleading because it refers to the date when articles were added to CORE, not when they were published. Furthermore, 'article_types' is not a usable field, and sorting is only available via a relevance score. I will contact CORE for clarification.
Thanks! Just a quick comment regarding publication date: I have seen the field datePublished, which seems to carry the publication date in the best resolution that they have. This would be similar to how publication date is reported in BASE and should do for our use case.
Are you referring to datePublished as returned by rcoreoa? I think this is the value we get in the returned metadata, but not what CORE allows us to search in their API.
@sckott I attempted an implementation of a language search param in rcoreoa, please see PR. Unfortunately this does not have any effect as some of my tests with English/en, French/fr, or German/de showed - but perhaps I'm missing something in the rcoreoa - thanks for having a look!
@chreman did feedback
just in case: note that the core_journals function is broken right now i think becaus somethin's broken on their end https://github.com/ropensci/rcoreoa/issues/17
@chreman Have you tried this recently? It should all be working on the rcoreoa side of things