OpenKh icon indicating copy to clipboard operation
OpenKh copied to clipboard

OpenKh.Command.HdAssets Does Not Support PS3 Variants

Open Vladabdf opened this issue 4 years ago • 6 comments

Both the "extract" and "strip" command arguments do nothing with PS3 assets. I have only tested this with 2.5 (KH2) however, as I don't have a hashlist to dump 1.5 or BbS HD.

Vladabdf avatar May 14 '20 18:05 Vladabdf

Does it work with PS4 remsters?

Xeeynamo avatar May 14 '20 18:05 Xeeynamo

Works perfectly fine on all PS4 remasters I tried it on, though I have yet to try DDD. I will do that real quick.

Vladabdf avatar May 14 '20 18:05 Vladabdf

Probably PS3 remasters uses some weird big endian stuff

Xeeynamo avatar May 14 '20 19:05 Xeeynamo

System.ArgumentOutOfRangeException: Not negative number needed. The HdAsset header is all big endian :/ P_EX100.zip

Rikux3 avatar May 14 '20 19:05 Rikux3

A quick idea that comes in my mind is to manually check if the first integer is greater than 0x1000000 to check the endian-ness to load the right endian for BinaryMapper. Hacky, but it does the trick and we do not have to bother about HdAssets ever anymore. BinaryMapper has to be updated to 1.5.0 across the entire solution though.

Xeeynamo avatar May 14 '20 19:05 Xeeynamo

Confirmed to work even with DDD on PS4. This info + the implementation for PS3 assets (regardless of how hacky it is, as long as it works) means the tool should be complete.

Vladabdf avatar May 14 '20 19:05 Vladabdf

No need for the support anymore; PS3 and PS4 versions are considered deprecated as of the PC release, and supporting the PS3 copies of the games is honestly too much effort that would be met with no fanfare whatsoever.

Vladabdf avatar Aug 03 '23 02:08 Vladabdf

Imho would still be a nice to have eventually.

Delta-473 avatar Aug 03 '23 07:08 Delta-473