open-interpreter icon indicating copy to clipboard operation
open-interpreter copied to clipboard

Fix JSONDecodeError for Ollama and hide LiteLLM vision support warning

Open CyanideByte opened this issue 1 year ago • 2 comments

Describe the changes you have made:

  • Disabled function calling for ollama which fixes "json.decoder.JSONDecodeError: Unterminated string starting at: line 1 column 2 (char 1)"
  • Hides a LiteLLM warning that the model doesn't support vision

Reference any relevant issues (e.g. "Fixes #000"):

  • Fixes https://github.com/OpenInterpreter/open-interpreter/issues/1514
  • Fixes https://github.com/OpenInterpreter/open-interpreter/issues/1512
  • Fixes https://github.com/OpenInterpreter/open-interpreter/issues/1371

Pre-Submission Checklist (optional but appreciated):

  • [ ] I have included relevant documentation updates (stored in /docs)
  • [x] I have read docs/CONTRIBUTING.md
  • [x] I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • [x] Tested on Windows
  • [ ] Tested on MacOS
  • [ ] Tested on Linux

CyanideByte avatar Nov 05 '24 06:11 CyanideByte

#1514

Notnaton avatar Nov 12 '24 08:11 Notnaton

Does litellm have a dict of which model/provider supports function calling?

If function call fail, should we set the --no-supports_function_calling flag automatically?

Notnaton avatar Nov 12 '24 12:11 Notnaton