open-interpreter icon indicating copy to clipboard operation
open-interpreter copied to clipboard

Remove pydantic warnings

Open imapersonman opened this issue 10 months ago • 3 comments

Describe the changes you have made:

This PR fixes two bugs:

  1. ~This line in start_terminal_interface.py was accidentally deleted at some point. Not sure when, and not sure if anyone else is seeing this, as I'm not seeing it reported as an issue anywhere. In any case I added the line back in and there's no longer a crash for a missing variable here.~
    • Fixed in #1187
  2. A bunch of pydantic-related warnings were being printed at startup. This appears to have been happening during LiteLLM's import here. I wrote instructions for how to reproduce this error in a simplified environment in this gist. I capped LiteLLM's version to the most recent update that doesn't display the warnings, but this cap is not ideal. I'll keep an eye on LiteLLM's repo to see when this issue is resolved and will remove the cap when it has been.

Relevant Issues

  • Fixes #1176

Pre-Submission Checklist (optional but appreciated):

  • [ ] I have included relevant documentation updates (stored in /docs)
  • [x] I have read docs/CONTRIBUTING.md
  • [x] I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • [ ] Tested on Windows
  • [x] Tested on MacOS
  • [ ] Tested on Linux

imapersonman avatar Apr 08 '24 02:04 imapersonman

I tested on Windows and confirmed it does fix the issue. Excellent PR. @imapersonman do you know if there is an issue about this opened on litellm yet?

CyanideByte avatar Apr 08 '24 03:04 CyanideByte

I tested on Windows and confirmed it does fix the issue. Excellent PR. @imapersonman do you know if there is an issue about this opened on litellm yet?

Thanks for testing the PR and for the kind words!

This issue in the LiteLLM repo describes the same bug.

imapersonman avatar Apr 08 '24 03:04 imapersonman

I tested on Windows and confirmed it does fix the issue. Excellent PR. @imapersonman do you know if there is an issue about this opened on litellm yet?

Thanks for testing the PR and for the kind words!

This issue in the LiteLLM repo describes the same bug.

I tested and your solution worked for me on Windows 11 Pro. Thank you you're awesome. :-)

johnsonblue75 avatar Apr 09 '24 00:04 johnsonblue75

Thank you for the PR @imapersonman! Much appreciated

MikeBirdTech avatar Apr 09 '24 15:04 MikeBirdTech

Clean and simple. Many, many thanks @imapersonman, great work!

KillianLucas avatar Apr 10 '24 00:04 KillianLucas