oi-userland icon indicating copy to clipboard operation
oi-userland copied to clipboard

Add Mail::SPF perl module

Open fritzkink opened this issue 1 year ago • 3 comments

@mtelka please check why tests are not working. Also please check why *.p5m was not fully build correctly and whether my adaptions in perl-integrate-module.conf are reasonable.

fritzkink avatar Sep 26 '22 20:09 fritzkink

@mtelka please check why tests are not working. Also please check why *.p5m was not fully build correctly and whether my adaptions in perl-integrate-module.conf are reasonable.

The first problem you have is license. You need %hook-no-license% to solve that.

Since this module primarily supports modulebuild you should switch to BUILD_STYLE = modulebuild. This should solve the problem with installation and sample-manifest.

For an example how to do that (all of the above) please look at Encode-Detect/perl-integrate-module.conf.

For failed tests you need to find the root cause of the failure and solve that.

There is also one additional problem: usr/sbin/spfd. This file cannot be installed like that because you'll end up with two packages (-534 and -536) containing the same file. Such packages would be impossible to install together.

mtelka avatar Sep 26 '22 21:09 mtelka

Thanks should be ok now.

fritzkink avatar Sep 27 '22 17:09 fritzkink

@mtelka: is this ready for merge now?

AndWac avatar Oct 03 '22 09:10 AndWac

Are there any further comments/suggerstions?

fritzkink avatar Oct 30 '22 17:10 fritzkink

Are there any further comments/suggerstions?

You didn't respond yet to my comment https://github.com/OpenIndiana/oi-userland/pull/9358#discussion_r986140941.

mtelka avatar Oct 30 '22 20:10 mtelka

@fritzkink, please fix the following problem. Thanks.

# pkg install -v library/perl-5/mail-spf
Creating Plan (Checking for conflicting actions): /           Packages to install:  3
       Create boot environment: No
Create backup boot environment: No
          Rebuild boot archive: No

Changed packages:
openindiana.org
  library/perl-5/mail-spf
    None -> 2.9.0-2022.0.0.0
  library/perl-5/mail-spf-534
    None -> 2.9.0-2022.0.0.0
  library/perl-5/mail-spf-536
    None -> 2.9.0-2022.0.0.0

pkg install: The following packages deliver conflicting action types to usr/bin/spfquery:

  file:
    pkg://openindiana.org/library/[email protected],5.11-2022.0.0.0:20221001T152656Z
  link:
    pkg://openindiana.org/library/perl-5/[email protected],5.11-2022.0.0.0:20221030T185222Z
    pkg://openindiana.org/library/perl-5/[email protected],5.11-2022.0.0.0:20221030T185225Z

These packages cannot be installed together. Any non-conflicting subset
of the above packages can be installed.
#

mtelka avatar Oct 30 '22 22:10 mtelka

thank you for catching this conflict. New pull request uploaded.

fritzkink avatar Oct 31 '22 19:10 fritzkink