oi-userland icon indicating copy to clipboard operation
oi-userland copied to clipboard

Add checksum file support to prep-download.mk + some sanity checks

Open dbh201 opened this issue 3 years ago • 4 comments

dbh201 avatar Sep 10 '22 15:09 dbh201

How should a new source file be downloaded with this?

AndWac avatar Sep 10 '22 17:09 AndWac

The hash/sig variables take priority, so no changes are required unless both variables are missing from the Makefile. If both are missing then you need to add 'ALLOW_UNVERIFIED_DOWNLOADS=yes' to the Makefile.

I have a couple ideas for improving it but I haven't fleshed them out yet. At the moment it's just an option to download the checksum file yourself and add it to the component directory, but I want to do automatic downloading of checksum files (based on a list of typical filenames, or COMPONENT_CHECKSUM_FILE), putting them in $(COMPONENT_DIR)/checksums/ and then adding them to the clobber list.

dbh201 avatar Sep 10 '22 18:09 dbh201

I have seen this variable. I think we should at least document its usage in our doc/makefile-target.txt

AndWac avatar Sep 10 '22 18:09 AndWac

I moved a lot of this functionality into userland-fetch. I'll have to look this over and make some changes. I'll be sure to explain any new variables in the docs.

dbh201 avatar Sep 16 '22 17:09 dbh201