oi-userland icon indicating copy to clipboard operation
oi-userland copied to clipboard

Added python/bleach

Open erwinlem opened this issue 3 years ago • 1 comments

Started porting matrix-synapse, this is one of the dependencies. I did make REQUIRED_PACKAGES but it did not pickup python as a dependency, is this correct?

erwinlem avatar Aug 15 '22 15:08 erwinlem

Yes, our dependency checker is weak to detect scripting language dependencies.

AndWac avatar Aug 15 '22 16:08 AndWac

Please use python-integrate-project to integrate this project. Thanks.

mtelka avatar Nov 14 '22 12:11 mtelka

python-integrate-projec works really well, but not all packages for testing are there so i will skip that for now.

erwinlem avatar Dec 08 '22 13:12 erwinlem

I do not recommend to merge this yet since python-integrate-project failed with ERRORs. The merge should be postponed until all packages needed for testing are merged first and tests are run. The list of missing packages is: black, hashin, mypy, pip-tools, sphinx, twine. I already had three of them in my queue and I just added rest to the queue too.

mtelka avatar Dec 08 '22 13:12 mtelka

Hmmm, it is not possible to get bleach tested without bleach itself, so I've no objection to merge this as is (although I'd prefer a bit better integration, but this could be improved later).

mtelka avatar Dec 08 '22 15:12 mtelka

I tried adding the packages for testing as wel but this spirals out of control into a big yak shaving fest. I have Synapse running but python-integrate-project fails at sample manifest (works fine for matrix_common). I will look later into what is happening under the hood.

Maybe we should pickup the tests with the next bleach update when we have all the dependencies available.

erwinlem avatar Dec 08 '22 16:12 erwinlem