open-humans icon indicating copy to clipboard operation
open-humans copied to clipboard

My account > Public profile should be the public profile

Open madprime opened this issue 7 years ago • 7 comments

It should go to /user/username – not to the dashboard at /member/me.

And maybe the latter is entirely unnecessary. There could be an "edit profile" a user sees on the profile page itself, if a user is viewing their own profile.

madprime avatar Feb 13 '18 17:02 madprime

Hey, Do you mean /member/username?

troublemagnet avatar Feb 15 '18 15:02 troublemagnet

@troublemagnet thanks for the PR! I don't think this will close the issue – I'd like to see the edit profile button added, and potentially clean up removing the old /member/me if that's obsolete. (Don't worry about having to do this too – I can do it sometime soon.)

Our community pages in Outreachy are confusing, I think we've miscommunicated to potential applicants: our main site isn't the code we intend to invite folks to contribute to. Even though it's open source, it's a very complex starting point! Please check out ideas here if you'd like to do more stuff: http://openhumansfoundation.org/outreachy/ideas/

That said: all your comments on issues and PR are spot on! But not everyone has your skill. ;-) I'm going to remove links to this repository in Outreachy, because I feel bad about creating confusion.

madprime avatar Feb 15 '18 18:02 madprime

I'm a bit confused by that comment @madprime. It seems to me that https://www.openhumans.org/member/me/ already leads to the same public profile that https://www.openhumans.org/member/gedankenstuecke/ would yield, but in addition to the public profile it has the edit profile button on top and the left-side-menu for looking at all my data sources/projects?

Would you want to move the stuff that's right now member/me to member/username for cases where request.user.username == /member/username?

gedankenstuecke avatar Feb 16 '18 11:02 gedankenstuecke

Part of it. Yes, I want an "Edit profile" button to show up on the /member/username for the case (site user is the user in the profile). I also want completion of member/me/edit/ should also return to /member/username.

And as a result, I think the /member/me view could be removed entirely. I also think the side panel could disappear entirely from all other /member/me pages – now that there's a dropdown.

Does that make sense?

madprime avatar Feb 16 '18 12:02 madprime

The first part makes sense, got it now. I think I would keep the side menu around though, because that makes using your own profile easier. :)

gedankenstuecke avatar Feb 16 '18 13:02 gedankenstuecke

Did some back-and-forth with @gedankenstuecke in Slack. We concluded that the side-panel on "own profile" is more confusing – we looked at how Twitter manages this. Let's leave the other views with side panels.

Here's the updated changes that should occur, I think…

  1. In the navbar dropdown, My account → Public Profile should go to member-detail-direct
  2. In the corresponding template, the button for Contact member should instead be Edit profile (leading to my-member-profile-edit
  3. The view for my-member-profile-edit should return the user to member-detail-direct
  4. The side-panel for other "my-member" views should remove the "Public Profile" button and link to my-member-dashboard
  5. I'd like to add a separator in the dropdown separating "Public profile" from the stuff below, since they've become substantially different types of view. The section with three links below (Projects joined / My data / Account settings) might also have a dropdown header "Account management" – but not sure how this will look.

@troublemagnet Thanks so much for trying to address this in #730! You're welcome to try to make the updates I've described, but it might be easiest for me to do all this. :)

madprime avatar Feb 16 '18 18:02 madprime

@madprime Apologies for the inactivity, had mid term submissions at my university. Also about this issue and PR, since you suggest that it'll be the easiest for you to do it, I'll take up some thing else. :smiley:

troublemagnet avatar Feb 24 '18 09:02 troublemagnet