open-humans icon indicating copy to clipboard operation
open-humans copied to clipboard

Link to oh-proj-management on main site

Open gedankenstuecke opened this issue 7 years ago • 4 comments

This is to tie together a recent discussion with @danamlewis:

Every time I do work on a research project and updating and importing people from the data commons to a research project...I yearn for the "delete this un-legitimate participant" in whatever form ya'll plan to do that in. I think the laborious background work of seeing who's uploaded data, determining who is legit, getting that data, and THEN beginning to do the data cleaning work and everything else for the research..is a lot, and the background work can be simplified with some OH site tools to make it easier for data commons/project admins

Dana already had the idea of offering a filtering list on the Open Humans backend, which would allow project owners to include/exclude participants (see #644 and #657). Building such project lead features will certainly be useful to facilitate running projects. But there are lots of moving parts to it that have to be thought through, as this is a design decision that will affect many things. e.g. can project admins kick out participants? are participants being notified about this? can they sign up again in the future? should all o this be quietly done on the project backend site without participants knowing?

For that reason we should have a discussion about this before implementing the feature. 🙂

gedankenstuecke avatar Dec 28 '17 19:12 gedankenstuecke

I think there are a number of ways it can be implemented; the biggest question is what the OH community (of both end users, and project owners) would like in terms of transparency, etc.

My starting $.02:

  • Kicking out participants (aka, removing them from the project) - I don't care either way, as long as:
  • if they're not removed, I can otherwise have the ability as a project owner to mark users on the back end without legitimate data sources (e.g., they don't have diabetes and are not looping, therefore they should not be signed up for the OpenAPS Data Commons) so I don't constantly have to download whatever Data Selfie data they've added to the project, and constantly filter them. (This also means an inaccurate member count, because it includes anyone who's joined, whether or not they've uploaded data, and regardless of legitimate or relevant data sources to a particular project). Again, a number of ways to have this done technically.
  • I'd be fine with people being notified, or not. If they are notified, I imagine it would be an email saying "A project owner noticed you do not have the required data types/relevant data for this project. You have been removed from this project. If you believe this has been done in error, please contact the project owner." (or similar)

danamlewis avatar Dec 28 '17 19:12 danamlewis

see also https://github.com/OpenHumans/open-humans/issues/657#issuecomment-356682624

danamlewis avatar Jan 10 '18 17:01 danamlewis

@madprime and I discussed this issue today. Adding this into the main Open Humans site would be a huge pain in terms of maintainability, as it means we have to not only add these methods in the API, but also on the site itself right away.

To make the whole thing more maintainable the project admin interface would ideally be a separate site (see https://github.com/OpenHumans/oh-proj-management for a draft of this) that should be able to run stand alone and uses a project's master_token to offer an interface to the OH-API. This should make it much easier to extend the project admin interface, as any user can set up their own instance if they wish to (plus development versions are much easier to install than the full OH site!).

Open Humans could then run their own instance under e.g. projectadmin.openhumans.org and link to this instance from the main site, using a one-click solution that passes a project's master_token as a login, making it easy to use as well.

gedankenstuecke avatar Jan 11 '18 00:01 gedankenstuecke

Updating this issue: with many thanks to @rosygupta and @gedankenstuecke the planned project has been created but not fully deployed: https://github.com/OpenHumans/oh-proj-management

A remaining TODO is to link to it within the main site via master token (and have the app use this for a smooth login), as noted above. I've edited the issue title accordingly. :+1:

madprime avatar Sep 13 '18 19:09 madprime