MITK upgrade

[JostMigenda]

This combines work from the previous MITK upgrade effort and @alonsoJASL’s fork … and then rebased all of it onto of the current development branch. This was a bit of a painful rebase—going forward, we really should avoid having branches diverge for multiple years!—but José and I completed it this afternoon.

Next up, I’ll try to build it on my machine and see what further changes are needed. Therefore, I’ll leave this as a draft PR for now.

[github-actions[bot]]

:zap: Code Analysis Results :zap:

:red_circle: Cppcheck found 22 issues! Click here to see details.

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp#L1813-L1818

!Line: 1813 - style: Redundant initialization for 'scalars'. The initialized value is overwritten before it is read. [redundantInitialization]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp#L1806-L1811

!Line: 1806 - note: scalars is initialized

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Modules/CemrgAppModule/src/CemrgCommonUtils.cpp#L1813-L1818

!Line: 1813 - note: scalars is overwritten

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.h#L55-L60

!Line: 55 - style: The class 'AtrialFibresClipperView' does not have a constructor although it has private member variables. [noConstructor]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.h#L66-L71

!Line: 66 - style: The class 'AtrialFibresView' does not have a constructor although it has private member variables. [noConstructor]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp#L451-L456

!Line: 451 - style: Redundant initialization for 'radii'. The initialized value is overwritten before it is read. [redundantInitialization]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp#L450-L455

!Line: 450 - note: radii is initialized

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresClipperView.cpp#L451-L456

!Line: 451 - note: radii is overwritten

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.h#L53-L58

!Line: 53 - style: The class 'AtrialFibresLandmarksView' does not have a constructor although it has private member variables. [noConstructor]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.cpp#L392-L397

!Line: 392 - style: The scope of the variable 'distance' can be reduced. [variableScope]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresLandmarksView.cpp#L248-L253

!Line: 248 - style: Unused variable: fileRough [unusedVariable]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresVisualiseView.h#L50-L55

!Line: 50 - style: The class 'AtrialFibresVisualiseView' does not have a constructor although it has private member variables. [noConstructor]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L1794-L1799

!Line: 1794 - style: Condition '!userInputAccepted' is always true [knownConditionTrueFalse]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L1792-L1797

!Line: 1792 - note: Assignment 'userInputAccepted=false', assigned value is 0

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L1794-L1799

!Line: 1794 - note: Condition '!userInputAccepted' is always true

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L2339-L2344

!Line: 2339 - style: Variable 'segImage' is assigned a value that is never used. [unreadVariable]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L192-L197

!Line: 192 - style: Redundant initialization for 'reply1'. The initialized value is overwritten before it is read. [redundantInitialization]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L189-L194

!Line: 189 - note: reply1 is initialized

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.atrialfibres/src/internal/AtrialFibresView.cpp#L192-L197

!Line: 192 - note: reply1 is overwritten

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.mmcwplugin/src/internal/MmcwView.cpp#L723-L728

!Line: 723 - style: Condition 'dcm_path_fix' is always true [knownConditionTrueFalse]

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.mmcwplugin/src/internal/MmcwView.cpp#L722-L727

!Line: 722 - note: Assignment 'dcm_path_fix=true', assigned value is 1

https://github.com/OpenHeartDevelopers/CemrgApp/blob/0c691e3b7b03fe1a3d333fc9ef261d51bbf2656d/CemrgApp/Plugins/kcl.cemrgapp.mmcwplugin/src/internal/MmcwView.cpp#L723-L728

!Line: 723 - note: Condition 'dcm_path_fix' is always true

[JostMigenda]

Test’s are failing during the “Download precompiled Build folder” step; no logs for that step is available, but the error message for the overall workflow run says: System.IO.IOException: No space left on device Is it possible that the downloaded build folder (plus the CemrgApp repo itself) exceeds the 14 GB disk space limit on GitHub’s runners?

Anyway, since the tests already fail on the head of the development branch, this shouldn’t stop us from merging this PR.