Chronicle-Wire icon indicating copy to clipboard operation
Chronicle-Wire copied to clipboard

implement missing ValueIn#sequence override for Text&YamlWire

Open JerryShea opened this issue 7 months ago • 0 comments

for Yaml & TextWire

    <T> boolean sequence(List<T> list, @NotNull List<T> buffer, Supplier<T> bufferAdd, Reader reader0) throws InvalidMarshallableException;

was not properly implemented - it's implementation instead the overload without the Reader.

This PR removes the stubbed implementations and ensures that the Reader argument is used. It also removes the net.openhft.chronicle.wire.ValueIn#sequence(java.util.List<T>, java.util.List<T>, java.util.function.Supplier<T>) overloads from the Text Wires as the default impl. interface already implements the correct behaviour.

JerryShea avatar May 30 '25 07:05 JerryShea