cosmos icon indicating copy to clipboard operation
cosmos copied to clipboard

Update Sum_of_digits_function.py

Open ManasGupta1998 opened this issue 7 years ago • 7 comments

Added a few comments

Fixes issue: #[Mention the issue number it fixes or add the details of the changes if it doesn't has a specific issue.]

Changes: [Add here what changes were made in this pull request.]

ManasGupta1998 avatar Nov 05 '17 07:11 ManasGupta1998

Kindly resolve the conflict. The folder mathematical-algorithms has been renamed to mathematical_algorithms. It will be good to merge after the minor change 👍

AdiChat avatar Nov 15 '17 18:11 AdiChat

@AdiChat I have renamed it

ManasGupta1998 avatar Nov 16 '17 10:11 ManasGupta1998

Also, remove the capital s, make it lowercase.

arnavb avatar Nov 16 '17 11:11 arnavb

@AdiChat This one should be merged, no ?

abdouskamel avatar Feb 09 '18 22:02 abdouskamel

This code achieves the same task and has the similar coding logic. 👍

AdiChat avatar Feb 12 '18 16:02 AdiChat

I think that the intention of the PR is not to add a new implementation of the algorithm, but to add comments to clarify the code and support only Python 3 as stated in the Python style guide (here).

If so, @ManasGupta1998, you should update the current code rather than creating a new one.

Vitorvgc avatar Feb 12 '18 19:02 Vitorvgc

@ManasGupta1998 Here is another reminder to make the changes suggested by Vitorvgc so that this can be merged as soon as possible.

arnavb avatar Apr 09 '18 15:04 arnavb