cosmos-search icon indicating copy to clipboard operation
cosmos-search copied to clipboard

Published 20 hours ago • verified publisher icon OpenGenus

Search results from trusted sites

Open sarvanideekshitula opened this issue 6 years ago • 5 comments

Checklist

  • [x] My branch is up-to-date with the upstream develop branch.
  • [ ] I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes: #91

sarvanideekshitula avatar Mar 14 '18 12:03 sarvanideekshitula

@AdiChat Please review

sarvanideekshitula avatar Mar 16 '18 17:03 sarvanideekshitula

Nice work :+1:

For the UI point of view, you may keep the style of external site results similar to the result from Cosmos. Additionally, you may fetch details for the result and display them under them as well for easy browsing.

Currently, when there are no results from Cosmos, it returns the no results page and the external site result follows. You need to consider this scenario and also, consider the case of calculations for which there are no external site results.

The titles for results are not correct. See results for linear search. Also, you must open links on a new tab and the links should be the links to the site but currently, it goes through Google google.com/url=....

Kindly take a look into this and make appropriate changes. :+1:

AdiChat avatar Mar 17 '18 17:03 AdiChat

@sarvanideekshitula Any update on this?

You have made an important contribution which requires minor changes as stated above to make it perfect.

If you facing any issues, kindly let us know and we will help you. Keep us updated on your progress. :+1:

AdiChat avatar Apr 04 '18 12:04 AdiChat

Great work :+1:

Instead of "solution", use the text "see more". Move the results to a tab named "External". The current code results from Cosmos should be available at the tab "Code". The tabs must be under the search bar. This is required as the number of code results from Cosmos can be large in some cases. The default tab must be named "All" which will include both the results. This will be a minor UI change.

Also, consider the no results page.

Kindly take a look and make appropriate changes. :+1:

AdiChat avatar Apr 07 '18 11:04 AdiChat

Nice work :+1:

The UI looks perfect.

The issue is that we will be sending requests from a single IP due to which it will get blocked. The solution around this is to create a sitemap including the site description for our use. This can be done by searching the search term site:stackoverflow.com and storing all the results. We need to search our stored results to present the results to the user.

Kindly take a look at this and make appropriate changes. :+1:

AdiChat avatar Apr 08 '18 04:04 AdiChat