cosmos-search icon indicating copy to clipboard operation
cosmos-search copied to clipboard

Voting feature of anonymous user

Open Shweta4321 opened this issue 6 years ago • 15 comments

Checklist

  • [X] My branch is up-to-date with the upstream develop branch.
  • [ ] I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes: #60

Why do we need this PR?: This would let the user rate the search result on scale of 1 to 5. It store the votes in database along with IP address and algorithm name .

If relevant, please include a screenshot. screenshot from 2018-02-28 13-06-50 screenshot from 2018-02-28 13-37-47

Shweta4321 avatar Feb 28 '18 08:02 Shweta4321

Nice work :+1:

You need to resolve the Travis error django.db.utils.OperationalError: no such table: search_votes. You need to register the Votes model in setting.py.

In terms of UI, you must remove the submit button and an entry must be made as soon as the user interacts with it. The average rating (in a format like [4.9 :star:] ) should appear beside the algorithm name. You must, also, make a default entry of 5 rating for each algorithm, to begin with. :+1:

Kindly make appropriate changes and let us know when it is ready for review. :+1:

AdiChat avatar Mar 01 '18 20:03 AdiChat

OKK Sir

Shweta Kumari 3rd-year B.Tech. IT IIIT Vadodara

On Fri, Mar 2, 2018 at 1:49 AM, Aditya Chatterjee [email protected] wrote:

Nice work 👍

You need to resolve the Travis error django.db.utils.OperationalError: no such table: search_votes. You need to register the Votes model in setting.py.

In terms of UI, you must remove the submit button and an entry must be made as soon as the user interacts with it. The average rating (in a format like [4.9 ⭐️] ) should appear beside the algorithm name. You must, also, make a default entry of 5 rating for each algorithm, to begin with. 👍

Kindly make appropriate changes and let us know when it is ready for review. 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenGenus/cosmos-search/pull/73#issuecomment-369718181, or mute the thread https://github.com/notifications/unsubscribe-auth/AWPbVyHB1BXgC1ccXDSTsx6zpVimLlF5ks5taFflgaJpZM4SWO6h .

Shweta4321 avatar Mar 02 '18 18:03 Shweta4321

@AdiChat The build is failing because there are no commands regarding makemigrations and migrate in travis.yml. Shall i raise issue for the same? It works on my pc. screenshot from 2018-03-04 01-45-34 Travis output. screenshot from 2018-03-04 01-45-05

Shweta4321 avatar Mar 03 '18 20:03 Shweta4321

I think you can remove the table from your local DB, maybe it will regenerate the error on your PC, then you can fix it.

soc221b avatar Mar 05 '18 15:03 soc221b

@iattempt I have already tried it. The main problem is as travis is not executing makemigrations and migrate command. So,it does not know about change in database hence this error occurs.

Shweta4321 avatar Mar 05 '18 17:03 Shweta4321

Did you try to adding command python3 manage.py makemigrations to travis before test command?

soc221b avatar Mar 05 '18 19:03 soc221b

screen shot 2018-03-06 at 3 53 46 am screen shot 2018-03-06 at 3 54 47 am

soc221b avatar Mar 05 '18 19:03 soc221b

@AdiChat Please review.

Shweta4321 avatar Mar 24 '18 08:03 Shweta4321

As we are expanding to other sources of search results, providing feedback option to only Cosmos results may be odd.

You may convert this to a general feedback form located at the lower right corner as a popup. In addition to voting, you may add an option to add a comment and also, store the current url/ search term. The general structure should remain the same.

We can use this data to provide additional insights to users like trending search terms, better recommendations and others.

Kindly take a look into this. :+1:

AdiChat avatar Mar 30 '18 23:03 AdiChat

@AdiChat please review

Shweta4321 avatar Apr 02 '18 12:04 Shweta4321

@AdiChat Please Review

Shweta4321 avatar Apr 07 '18 13:04 Shweta4321

@AdiChat Please Review

Shweta4321 avatar Apr 12 '18 14:04 Shweta4321

You must clean this pull request regarding manage.py 100755 → 100644, Submodule cosmos deleted from 2006c2 and similar changes.

AdiChat avatar Apr 13 '18 15:04 AdiChat

@AdiChat please Review

Shweta4321 avatar Apr 14 '18 08:04 Shweta4321

Nice work :+1:

It is intended to be a general voting section instead of being tied to a particular result. This requires a redesign of the UI to the lower right corner as a popup.

In the current design, voting reloads the page but ideally, it should cover everything in the background. For comments/ discussions, we must use our Discourse forum.

Instead of asking users to rate, we can ask a specific question like "What do you like about this page?" with options like "Code results, Video results, Everything". You can, also, take a look at third-party integrations that can provide such a solution.

Kindly take a look into this. :+1:

AdiChat avatar Apr 14 '18 15:04 AdiChat