Strata icon indicating copy to clipboard operation
Strata copied to clipboard

Dependency convergence warning for joda-convert

Open dsubelman opened this issue 3 years ago • 1 comments

Maven Enforcer Plugin reports a dependency convergence error for joda-convert (v2.2.1 / v2.2.2).

Strata declare dependencies joda-convert v2.2.2 and joda-beans v2.8.1. On the other hand, joda-beans declare dependency joda-convert but version 2.2.1.

I haven't found any specific issue related to this warning. However, I thought you should know in case you see any possible issues.

Strata v2.10.23 JDK 17 MacOS BigSur v11.6

Maven enforcer plugin warning:

Dependency convergence error for org.joda:joda-convert:jar:2.2.1:compile paths to dependency are:
+-com.root:module:jar:1.0
  +-com.opengamma.strata:strata-measure:jar:2.10.23:compile
    +-com.opengamma.strata:strata-collect:jar:2.10.23:compile
      +-org.joda:joda-beans:jar:2.8.1:compile
        +-org.joda:joda-convert:jar:2.2.1:compile
and
+-com.root:module:jar:1.0
  +-com.opengamma.strata:strata-measure:jar:2.10.23:compile
    +-com.opengamma.strata:strata-collect:jar:2.10.23:compile
      +-org.joda:joda-convert:jar:2.2.2:compile
and
+-com.root:module:jar:1.0
  +-com.opengamma.strata:strata-measure:jar:2.10.23:compile
    +-com.opengamma.strata:strata-calc:jar:2.10.23:compile
      +-org.joda:joda-convert:jar:2.2.2:compile

A possible solution is to exclude joda-convert from joda-beans dependency in the POM.

Actual:

<dependency>
    <groupId>org.joda</groupId>
    <artifactId>joda-beans</artifactId>
    <version>${joda-beans.version}</version>
</dependency>

Proposed:

<dependency>
    <groupId>org.joda</groupId>
    <artifactId>joda-beans</artifactId>
    <version>${joda-beans.version}</version>
    <exclusions>
        <exclusion>
            <groupId>org.joda</groupId>
            <artifactId>joda-convert</artifactId>
        </exclusion>
    </exclusions>
</dependency>

dsubelman avatar Dec 22 '21 20:12 dsubelman

Thanks for the info. This isn't something we would seek to address. The Joda-Convert releases are equivalent as far as Strata is concerned, so there is no need to achieve convergence.

jodastephen avatar Jan 06 '22 12:01 jodastephen

Convergence issue solved. Strata v2.12.36 declares Joda-Beans v2.10.0. Both versions of Strata and Joda-Beans declare the same version of Joda-Convert: v2.2.3.

dsubelman avatar Mar 24 '24 15:03 dsubelman

收到!

ElonVampire avatar Mar 24 '24 15:03 ElonVampire