functions-framework-go icon indicating copy to clipboard operation
functions-framework-go copied to clipboard

add more params to dapr pubsub subscription

Open halegreen opened this issue 3 years ago • 6 comments

fix issue: https://github.com/OpenFunction/OpenFunction/issues/329

halegreen avatar Jul 23 '22 14:07 halegreen

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 23 '22 14:07 CLAassistant

@tpiperatgod @wrongerror hi , any suggestions on this pr?

halegreen avatar Jul 29 '22 14:07 halegreen

See my comments in https://github.com/OpenFunction/OpenFunction/pull/332

benjaminhuo avatar Aug 29 '22 07:08 benjaminhuo

See my comments in OpenFunction/OpenFunction#332

fixed it . please have a look.

halegreen avatar Feb 19 '23 06:02 halegreen

See my comments in OpenFunction/OpenFunction#332

fixed it . please have a look.

Please make sure this pr does not conflict with #66, they both set the route.

wanjunlei avatar Feb 20 '23 01:02 wanjunlei

See my comments in OpenFunction/OpenFunction#332

fixed it . please have a look.

Looks like still not fixed https://github.com/OpenFunction/OpenFunction/pull/332#discussion_r956705524: image

benjaminhuo avatar Feb 23 '23 09:02 benjaminhuo