OpenFunction icon indicating copy to clipboard operation
OpenFunction copied to clipboard

Is the deploy.sh still valid?

Open FeynmanZhou opened this issue 3 years ago • 6 comments

As ofn CLI has been officially recommended by the OpenFunction community, and the old install/uninstall scripts deprecation was mentioned in v0.5.0 release notes, is the deploy.sh and delete.sh still valid for the old version of OpenFunction?

FeynmanZhou avatar Dec 31 '21 03:12 FeynmanZhou

It's still valid but not recommended anymore. It's not removed because CI is still using these. @tpiperatgod Do we have a plan to replace deploy.sh/deleted.sh with ofn in CI? You mentioned we need changes to ofn?

benjaminhuo avatar Dec 31 '21 03:12 benjaminhuo

To do that, we need an external environment to execute the GitHub action.

tpiperatgod avatar Dec 31 '21 03:12 tpiperatgod

As I know, SIG-DevOps KubeSphere is using Tekton in ks-devops CI with GitHub action. @tpiperatgod You can ask @Linuxsuren @johnniang for details.

FeynmanZhou avatar Dec 31 '21 03:12 FeynmanZhou

It looks like just need to add a action.yaml file to the cli and use ofn like this:

- name: Install dependent components
  uses: OpenFunction/cli@main 
  with:
    all: true

rainbend avatar Dec 31 '21 07:12 rainbend

It looks like just need to add a action.yaml file to the cli and use ofn like this:

- name: Install dependent components
  uses: OpenFunction/cli@main 
  with:
    all: true

yes, but it failed during installation and we think it may be a lack of sufficient resources..

tpiperatgod avatar Dec 31 '21 09:12 tpiperatgod

It looks like just need to add a action.yaml file to the cli and use ofn like this:

- name: Install dependent components
  uses: OpenFunction/cli@main 
  with:
    all: true

yes, but it failed during installation and we think it may be a lack of sufficient resources..

Regarding the limited resource issue, @wanjunlei handle it this way in the script approach: https://github.com/OpenFunction/OpenFunction/blob/main/.github/workflows/main.yaml#L81

benjaminhuo avatar Dec 31 '21 09:12 benjaminhuo