openfe
openfe copied to clipboard
Set PyMBAR solver to "robust" and use PyMBAR4
Checklist
- [ ] Added a
newsentry
Developers certificate of origin
- [x] I certify that this contribution is covered by the MIT License here and the Developer Certificate of Origin at https://developercertificate.org/.
Hello @hannahbaumann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2024-07-04 12:15:00 UTC
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.36%. Comparing base (
ecc8a50) to head (30b32e2). Report is 251 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 93.98% 91.36% -2.62%
==========================================
Files 134 134
Lines 9790 9790
==========================================
- Hits 9201 8945 -256
- Misses 589 845 +256
| Flag | Coverage Δ | |
|---|---|---|
| fast-tests | 91.36% <100.00%> (?) |
|
| slow-tests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
IMHO this should get a news entry since this change could cause a system to go from working to not working.
IMHO this should get a news entry since this change could cause a system to go from working to not working.
Agreed - this is more of a proof of concept at the moment, @RiesBen is taking over testing for this. We'll need to do a few PLB systems to convince ourselves that this works.
This should not be merged, because the fix is happening in openmmtools.