[DNM] lower limit to openff version?

[mikemhenry]

trafficstars

Checklist

• [ ] Added a news entry

Developers certificate of origin

• [ ] I certify that this contribution is covered by the MIT License here and the Developer Certificate of Origin at https://developercertificate.org/.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.13%. Comparing base (3b76941) to head (6779e09).

:exclamation: Current head 6779e09 differs from pull request most recent head be403e4. Consider uploading reports for the commit be403e4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   94.13%   92.13%   -2.01%     
==========================================
  Files         134      134              
  Lines        9786     9786              
==========================================
- Hits         9212     9016     -196     
- Misses        574      770     +196     

Flag	Coverage Δ
fast-tests	92.13% <ø> (?)
slow-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[mikemhenry]

ERROR openfe/tests/protocols/test_openmm_equil_rfe_protocols.py::test_tip4p_check_vsite_parameters - ValueError: No registered small molecule template generators could load force field 'openff-2.1.1'

we can't use openff-toolkit =0.13.x

[mikemhenry]

Well at least not with openff-2.1.1 ff, so since that is the only error, it might work with an older ff version

[IAlibay]

I'm really not sure how 0.13 handles things like NAGL - it might be best not to go below 0.14 if we can avoid it.