openfe icon indicating copy to clipboard operation
openfe copied to clipboard

Frequent "Should have \sum_n W_nk = 1" errors in analysis

Open tlhr opened this issue 1 year ago • 4 comments

I've noticed that for some systems legs fail due to:

ParameterError: Warning: Should have \sum_n W_nk = 1.  Actual column sum for state 0 was 0.990260. 15 other columns have similar problems

This example was an RBFE solvent leg running for 10 ns with 15 lambda windows, so I would have expected adequate sampling. Could it be related to this PyMBAR issue? My analysis succeeds when I force an update to PyMBAR 4.0.3 and modify MultistateEquilFEAnalysis to pass analysis_kwargs={"solver_protocol": "robust"} to MultiStateSamplerAnalyzer as suggested in the last comment. Maybe this could be made the default? I guess this is also related to #443.

tlhr avatar Apr 18 '24 11:04 tlhr

@RaphaelRobidas, Can I start working on this issue?

anmolchhabra21 avatar Feb 09 '24 13:02 anmolchhabra21

@anmolchhabra21 Yes, go ahead!

RaphaelRobidas avatar Feb 09 '24 13:02 RaphaelRobidas

@RaphaelRobidas can i work on it?

supreetkaursareen avatar Feb 12 '24 15:02 supreetkaursareen

@supreetkaursareen, you can move forward with it, I am bit occupied and it might take some time to come back.

anmolchhabra21 avatar Feb 13 '24 08:02 anmolchhabra21