openfe
openfe copied to clipboard
Add linting
Developers certificate of origin
- [x] I certify that this contribution is covered by the MIT License here and the Developer Certificate of Origin at https://developercertificate.org/.
black 120 chars
Codecov Report
Attention: 205 lines in your changes are missing coverage. Please review.
Comparison is base (
60a5eca) 93.73% compared to head (804a657) 91.89%.
Additional details and impacted files
@@ Coverage Diff @@
## main #723 +/- ##
==========================================
- Coverage 93.73% 91.89% -1.84%
==========================================
Files 133 133
Lines 9650 9645 -5
==========================================
- Hits 9045 8863 -182
- Misses 605 782 +177
| Flag | Coverage Δ | |
|---|---|---|
| fast-tests | 91.89% <89.79%> (?) |
|
| slow-tests | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
using isort on openfe/setup/__init__.py gives me errors like
E ImportError: cannot import name 'LomapAtomMapper' from partially initialized module 'openfe.setup' (most likely due to a circular import) (/home/mmh/Projects/openfe/openfe/setup/__init__.py)
From today's call: to be discussed in an upcoming power hour.
I have the same PR on GUFE, so we can talk about linting-org wide on a power hour