openfe icon indicating copy to clipboard operation
openfe copied to clipboard

Encourage properly setting residue names when building form SDF

Open IAlibay opened this issue 2 years ago • 3 comments
trafficstars

The UNK residue is rather meaningless. Is there a way we could enforce (at the SmallMoleculeComponent) both a warning & some kind of convenience method to override the residue name?

IAlibay avatar Jun 19 '23 14:06 IAlibay

UNK ain’t us. Sdfs won’t have populated the MonomerInfo struct, so I imagine this is something that OpenFF/OpenMM are doing.

On Mon, Jun 19, 2023 at 15:37, Irfan Alibay @.***> wrote:

The UNK residue is rather meaningless. Is there a way we could enforce (at the SmallMoleculeComponent) both a warning & some kind of convenience method to override the residue name?

— Reply to this email directly, view it on GitHub https://github.com/OpenFreeEnergy/openfe/issues/463, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGSGBYC4TXXF3GMDDTYEZ3XMBP3RANCNFSM6AAAAAAZMBK5P4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

richardjgowers avatar Jun 19 '23 14:06 richardjgowers

@richardjgowers it's a "partially us" problem, as you say SDFs don't set Monomerinfo, so we don't propagate the residue name through (so OpenFF / OpenMM just set it to UNK). What I'm saying here is that we should encourage users to propagate this information along. It's useful information that should be written into tthe system and we're not doing anything about it.

Our users are going to be very confused when they see the residue UNK and wonder why on earth that happened.

IAlibay avatar Jun 19 '23 22:06 IAlibay

Related: https://github.com/OpenFreeEnergy/gufe/issues/327

IAlibay avatar Jun 09 '24 15:06 IAlibay