lightning
lightning copied to clipboard
Remove Heroicons hex package
Description
This PR removes Heroicons (the hex package) in favour of using our Tailwind system.
Validation steps
Check the application for missing icons.
Additional notes for the reviewer
This can't be merged until downstream applications that expect Heroicons to be installed as a transistive dependency either add Heroicons or conform with the <.icon name="hero-..." /> component.
Pre-submission checklist
- [ ] I have performed a self-review of my code.
- [ ] I have implemented and tested all related authorization policies. (e.g.,
:owner,:admin,:editor,:viewer) - [ ] I have updated the changelog.
Codecov Report
Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.
Project coverage is 89.84%. Comparing base (
fc29ed4) to head (a3ff899). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/lightning_web/live/run_live/components.ex | 52.94% | 8 Missing :warning: |
| lib/lightning_web/live/modal_portal.ex | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
+ Coverage 89.79% 89.84% +0.04%
==========================================
Files 314 314
Lines 10842 10830 -12
==========================================
- Hits 9736 9730 -6
+ Misses 1106 1100 -6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.