lightning icon indicating copy to clipboard operation
lightning copied to clipboard

use monaco for dataclip viewer

Open midigofrank opened this issue 9 months ago • 1 comments

Validation Steps

How can a reviewer validate your work?

Notes for the reviewer

  • Deleted test/lightning_web/live/run_live/streaming_test.exs. It was testing for the scrubbed dataclip lines, so I have moved the test to the test/lightning_web/controllers/dataclip_controller_test.exs.

Checklist

  • [x] The dataclip type is no longer displayed on the step input/output dataclip viewers. I'm not sure how/where to put it
  • [x] Lazy load the monaco editor
  • [ ] Configure esbuild to split the monaco editor component bundle correctly?
  • [x] Fix failing tests
  • [ ] Do not wait for the whole response body to be loaded in order to display the content. Instead read the body on the fly
  • [ ] Only load the editor on visibility
  • [ ] Add HTTP Caching headers e.g. If-modified-since
  • [x] Some space appears if the dataclip is dropped/not saved, like seen in the screenshot below Screenshot 2024-05-16 at 14 45 02

Related issue

Fixes #1872

Review checklist

  • [ ] I have performed a self-review of my code
  • [ ] I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • [ ] If needed, I have updated the changelog
  • [ ] Product has QA'd this feature

midigofrank avatar May 14 '24 17:05 midigofrank

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.08%. Comparing base (a0709fb) to head (09f6dc9). Report is 4 commits behind head on main.

:exclamation: Current head 09f6dc9 differs from pull request most recent head 2e564a1

Please upload reports for the commit 2e564a1 to get more accurate results.

Files Patch % Lines
lib/lightning/dataclip_scrubber.ex 78.57% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.01%     
==========================================
  Files         254      257       +3     
  Lines        8286     8274      -12     
==========================================
- Hits         7465     7454      -11     
+ Misses        821      820       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 16 '24 11:05 codecov[bot]