lightning icon indicating copy to clipboard operation
lightning copied to clipboard

concept for fix

Open taylordowns2000 opened this issue 10 months ago • 1 comments

this is just a concept:

  1. needs testing
  2. maybe (probably) also needs the workflow to pull/merge previously made changes... see @mtuchi 's latest error when he reruns the workflow.
  • we want workflow a to run
  • then we want workflow b to run
  • they are both triggered by the same commit, but they do different things because we have multiple unrelated openfn projects in the same repo.
  • how do we stop the conflicts?

Maybe Fixes #2044

taylordowns2000 avatar Apr 25 '24 09:04 taylordowns2000

you can test this by modifying the workflow in place @mtuchi . the "fix" is just for automatically generated workflows from lightning.

taylordowns2000 avatar Apr 25 '24 09:04 taylordowns2000

@mtuchi I have tested that this actually runs the workflows one at a time. When you get some time, do modify the github workflows in the project with this option and see the how it works

midigofrank avatar Jun 03 '24 05:06 midigofrank

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.61%. Comparing base (0989196) to head (628bdef).

:exclamation: Current head 628bdef differs from pull request most recent head 73169aa

Please upload reports for the commit 73169aa to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
- Coverage   89.64%   89.61%   -0.03%     
==========================================
  Files         270      270              
  Lines        8943     8957      +14     
==========================================
+ Hits         8017     8027      +10     
- Misses        926      930       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 03 '24 05:06 codecov[bot]

We have tested with water-aid everything is working as expected

mtuchi avatar Jun 05 '24 10:06 mtuchi