querydsl icon indicating copy to clipboard operation
querydsl copied to clipboard

Revert "Temporaly disabling ksp testing"

Open velo opened this issue 1 year ago • 12 comments

This reverts commit 128a207d6c666f689b327cd205079ddbb76dc9bf.

velo avatar Dec 14 '24 11:12 velo

@IceBlizz6 made the issue a separated PR, any assistance you can give, would be appreciated

velo avatar Dec 14 '24 16:12 velo

I'm looking into it. Not currently able to recreate the issue, the project built as expected and all the tests ran successfully.

@velo Are you able to recreate this issue on your machine?

IceBlizz6 avatar Dec 14 '24 18:12 IceBlizz6

Nevermind, was able to recreate it now i think. Forgot to recreate the properties file with the new versions.

IceBlizz6 avatar Dec 14 '24 18:12 IceBlizz6

Seems to be solved by updating hibernate.version 7.0.0.Beta1 -> 7.0.0.Beta3

IceBlizz6 avatar Dec 14 '24 18:12 IceBlizz6

Seems to be solved by updating hibernate.version 7.0.0.Beta1 -> 7.0.0.Beta3

Ow, that is a problem https://github.com/OpenFeign/querydsl/pull/738

velo avatar Dec 15 '24 23:12 velo

I could try to take a closer look if there are other solutions, but i have some doubts of whether that is even an option. There will always be some risks when trying to use beta versions.

may i ask why we are trying to update to the hibernate beta version?

IceBlizz6 avatar Dec 15 '24 23:12 IceBlizz6

Jpa 3.2 support... And that is forcing java 11 out, that is why I decided to start a 7 series branch

velo avatar Dec 16 '24 01:12 velo

It looks like the error came from just trying to add a Kotlin entity class. So this issue may not be related to KSP at all.

Configuration()
            .setProperty(AvailableSettings.JAKARTA_JDBC_DRIVER, org.h2.Driver::class.qualifiedName!!)
            .setProperty(AvailableSettings.JAKARTA_JDBC_URL, "jdbc:h2:mem:my-database;")
            .setProperty(AvailableSettings.HBM2DDL_AUTO, "create-drop")
            .setProperty(AvailableSettings.SHOW_SQL, "true")
            .addAnnotatedClass(Person::class.java) // Fails only if this line is included
            .buildSessionFactory()
            .unwrap(EntityManagerFactory::class.java)

If this is correct then anyone with a kotlin project on hibernate would be unable to use beta1 anyway.

IceBlizz6 avatar Dec 16 '24 12:12 IceBlizz6

This pull request has been marked as stale due to inactivity.

github-actions[bot] avatar Mar 24 '25 01:03 github-actions[bot]

This pull request has been closed due to inactivity.

github-actions[bot] avatar Mar 31 '25 01:03 github-actions[bot]

This pull request has been marked as stale due to inactivity.

github-actions[bot] avatar May 01 '25 02:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (8e4720d) to head (d48a043). Report is 1 commits behind head on querydsl-7.0.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@              Coverage Diff              @@
##           querydsl-7.0    #735    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files               812     837    +25     
  Lines             31046   31376   +330     
  Branches           3506    3514     +8     
=============================================
- Misses            31046   31376   +330     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 01 '25 13:05 codecov[bot]