feign icon indicating copy to clipboard operation
feign copied to clipboard

Documentation for the metrics reported to micrometer when using MicrometerCapability

Open adispennette opened this issue 1 year ago • 5 comments

is there any documentation on what the various metric published by micrometer mean? I am making a lot of guesses but don't actually know for sure what they are relaying.

adispennette avatar Nov 27 '23 21:11 adispennette

We do need for someone do look under the hood and write proper docs for metrics.

Is pretty much reporting Timers for http client execution, encoding/deconding and overall time from invokation of feign method.

So you can track if a request is slow, and whos to blame

velo avatar Nov 27 '23 23:11 velo

Thanks for the comment @velo I am attempting to monitor the connection pools for each connection. I think I have the right metric with feign.Client.count or feign.Feign.count since they seem to be the same thing. I am also looking at injecting a custom okhttp client that has the pool monitor configured in as well. But I do like the other metrics.

adispennette avatar Nov 28 '23 16:11 adispennette

the count will only diverge when there are retries. 99% of times it will be the same.

velo avatar Nov 28 '23 17:11 velo

In addition it'd be helpful to document metrics published by MicrometerObservationCapability.

AlexElin avatar Jan 28 '24 22:01 AlexElin

In addition it'd be helpful to document metrics published by MicrometerObservationCapability.

That would be awesome. Please send a PR, I will make sure to approve it.

velo avatar Jan 28 '24 23:01 velo