feign icon indicating copy to clipboard operation
feign copied to clipboard

Undefined value in @QueryMap params works not as described

Open niktsar opened this issue 2 years ago • 1 comments

Here is description of behavior for undefined values https://github.com/OpenFeign/feign/blob/master/README.md#undefined-vs-empty-values

When I try to call client like this:

Map<String, Object> parameters = new LinkedHashMap<>();
parameters.put("param", null);
this.demoClient.test(parameters);

URL looks like /demo/client/url?param

Up to readme description, here https://github.com/OpenFeign/feign/blob/248871dede1a00afab14dd12c0f18383aa10462e/core/src/main/java/feign/ReflectiveFeign.java#L300 need to add filter of null values. Could you please confirm is it bug, or I misunderstand the description?

niktsar avatar Sep 16 '21 14:09 niktsar

Passed the test, i think that it is a bug.

image

image

mroccyen avatar Mar 04 '22 02:03 mroccyen