Error updating all mods (listAllMods npe)

[knoxfighter]

I noticed an error message popping up, when updating all mods (had 5 to update). The first three went through without any problems the other 2 had error messages showing up.

Log of that happening: https://pastebin.com/ymrQS7cW

My guess: A racecondition i when running the filepath walker. It creates a list of all the files internally, but when our code is called, that file already got deleted by another coroutine. Possible solutions:

• Check info and filePath for nil (if they are nil at this point, they could also lead to invalid data)
• Rewriting how updating all mods work (the preffered way, cause the current implementation was only a temporary solution) Additionally i would recommend, that removing that race-condition at all would be great (handle file watching and more by ourselves), or any other way you can think of.

To describe my guessed race condition:

• Multiple update calls are done simultaniously
• Downloading new mod 1
• Downloading new mod 2
• Saving new mod 1
• Saving new mod 2
• Delete old mod 1
• List all mods in mod 1
• Delete old mod 2
• List all mods in mod 2
• Iterate over all files in mod 1
• Crash, cause the file for old mod 2 is not there anymore

[knoxfighter]

After this error occured, the mod miniloader was missing and i am unable to install it again. Manually installing is still possible.

2021/07/12 23:24:04 skipping dependency '? angelsindustries >= 0.4.9' in 'angelsaddons-cab': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobenemies >= 0.18.5' in 'angelsbioprocessing': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobenemies >= 0.18.5' in 'angelsexploration': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobwarfare >= 0.18.6' in 'angelsexploration': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? angelsindustries >= 0.4.9' in 'angelsaddons-cab': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobassembly >= 0.18.6' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) boblogistics >= 1.0.0' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobtech >= 0.18.3' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobrevamp >= 0.18.5' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) aai-industry >= 0.4.12' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobplates >= 0.18.8' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobassembly >= 0.18.5' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobrevamp >= 0.18.5' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobenemies >= 0.18.5' in 'angelsbioprocessing': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobenemies >= 0.18.5' in 'angelsexploration': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobwarfare >= 0.18.6' in 'angelsexploration': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobplates >= 0.18.8' in 'angelssmelting': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobassembly >= 0.18.6' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) boblogistics >= 1.0.0' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobtech >= 0.18.3' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobrevamp >= 0.18.5' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) aai-industry >= 0.4.12' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobplates >= 0.18.8' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobassembly >= 0.18.5' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobrevamp >= 0.18.5' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? bobplates >= 0.18.8' in 'angelssmelting': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? base >= 1.1.19' in 'flib': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? base >= 1.1.19' in 'flib': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '(?) bobinserters >= 0.17.1' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? boblogistics >= 0.17.1' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? FactorioExtended-Plus-Transport >= 0.1.5' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? Krastorio2 >= 0.9.0' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? RandomFactorioThings >= 1.0.0' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? UltimateBelts >= 0.16.4' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? UltimateBelts_Owoshima_And_Pankeko-Mod >= 0.16.4' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:04 skipping dependency '? space-exploration >= 0.1.95' in 'miniloader': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? angelsindustries >= 0.4.9' in 'angelsaddons-cab': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobenemies >= 0.18.5' in 'angelsbioprocessing': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobenemies >= 0.18.5' in 'angelsexploration': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobwarfare >= 0.18.6' in 'angelsexploration': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '(?) bobassembly >= 0.18.6' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '(?) boblogistics >= 1.0.0' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '(?) bobtech >= 0.18.3' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '(?) bobrevamp >= 0.18.5' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '(?) aai-industry >= 0.4.12' in 'angelsindustries': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobplates >= 0.18.8' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobassembly >= 0.18.5' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobrevamp >= 0.18.5' in 'angelspetrochem': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? bobplates >= 0.18.8' in 'angelssmelting': optional dependency or invalid format
2021/07/12 23:24:25 skipping dependency '? base >= 1.1.19' in 'flib': optional dependency or invalid format
2021/07/12 23:24:26 download complete
 StatusCode: 200
 Status: 200 OK
2021/07/12 23:24:26 the mod-file for mod miniloader doesn't exist!
2021/07/12 23:24:26 error when deleting mod: the mod-file for mod miniloader doesn't exist!
2021/07/12 23:24:26 error when creating Mod: the mod-file for mod miniloader doesn't exist!
2021/07/12 23:24:26 Error downloading a mod: the mod-file for mod miniloader doesn't exist!

[Bykow]

I think I noticed optionnal dependencies not being correctly uptaded