openfast
openfast copied to clipboard
Disallow building with shared libraries and MSVC
Feature or improvement description This pull requests disallows building with shared libraries while using the MSVC build tool.
Related issue, if one exists https://github.com/OpenFAST/openfast/issues/448
Impacted areas of the software CMake on Windows with MSVC
Additional supporting information ~Not tested!~
Test results, if applicable ~Not tested!~
Update 5/12/2021: I've verified that with BUILD_SHARED_LIBS=ON
, the build system (tested with NMake) cannot find the required .libs
that should accompany a .dll
. I've also verified that the error message in this pull request prevents the configuration when using MSVC and BUILD_SHARED_LIBS=ON
. The MSVC CMake variable is True even when using all Intel compilers.
My recent recent pull request #1010 might address this issue more directly.
Closing this due to inactivity (and @rafmudaf said I can).