openfast icon indicating copy to clipboard operation
openfast copied to clipboard

Disallow building with shared libraries and MSVC

Open rafmudaf opened this issue 3 years ago • 1 comments

Feature or improvement description This pull requests disallows building with shared libraries while using the MSVC build tool.

Related issue, if one exists https://github.com/OpenFAST/openfast/issues/448

Impacted areas of the software CMake on Windows with MSVC

Additional supporting information ~Not tested!~

Test results, if applicable ~Not tested!~

Update 5/12/2021: I've verified that with BUILD_SHARED_LIBS=ON, the build system (tested with NMake) cannot find the required .libs that should accompany a .dll. I've also verified that the error message in this pull request prevents the configuration when using MSVC and BUILD_SHARED_LIBS=ON. The MSVC CMake variable is True even when using all Intel compilers.

rafmudaf avatar Mar 28 '21 22:03 rafmudaf

My recent recent pull request #1010 might address this issue more directly.

reos-rcrozier avatar Feb 22 '22 10:02 reos-rcrozier

Closing this due to inactivity (and @rafmudaf said I can).

andrew-platt avatar Oct 26 '22 20:10 andrew-platt