openfast icon indicating copy to clipboard operation
openfast copied to clipboard

More bug fixes in the WAMIT and WAMIT2 modules of HydroDyn with wave headings

Open luwang00 opened this issue 11 months ago • 0 comments

Feature or improvement description The PR contains several bug fixes for the WAMIT and WAMIT2 modules of HydroDyn. The bugs are related to the handling of wave headings,

In WAMIT:

  • When NBodyMod=2, PtfmRefztRot was not accounted for when checking the WAMIT wave headings.
  • The previous correction of WAMIT wave heading when NBodyMod=2 will lead to interpolating out of range.
  • The phase shift of wave elevation for the state-space wave-excitation model was implemented incorrectly.

In WAMIT2:

  • The checking of WAMIT wave frequencies were not functioning as intended and were unnecessary. This is simply removed.
  • The checking of WAMIT wave headings is moved to separate subroutines to minimize code duplication.
  • The checking of WAMIT wave headings did not account for PtfmRefztRot when NBodyMod=2. This is now corrected.

Impacted areas of the software HydroDyn

Test results, if applicable No change to existing test results. Will need more r-tests in the future to cover the various options of HydroDyn.

luwang00 avatar Mar 15 '24 22:03 luwang00