openfast icon indicating copy to clipboard operation
openfast copied to clipboard

New AeroDyn input file exposing new BEM options (polar BEM, skew momentum correction, sector averaging)

Open ebranlard opened this issue 1 year ago • 1 comments

This pull request is ready to be merged

See : https://github.com/OpenFAST/openfast/discussions/1895

Feature or improvement description

  • New AeroDyn input file
  • Sector averaging (for shear)
  • Skew momentum correction (for skew)
  • Polar BEM

Related issue, if one exists

  • Input file changes: # 1895
  • Link to other pull requests: dev-unstable-pointers

Impacted areas of the software AeroDyn

Test results No change expected as this introduces new options, and the input file is read as backward compatible.

  • [x] Finish pull request
  • [x] Make sure connections for the Shear weighting is done
  • [x] Document changes - Live doc here
  • [x] Add example file , here

Future pull request

  • Change all the r-test input files
  • Add aerodyn test case for new features

ebranlard avatar Dec 01 '23 02:12 ebranlard

This pul request is ready for review. Becasue it relies on dev-unstable-pointers, I would like to recommend merging it now at this point, so that others start to use it and potentially give feedback / bug fixes. The implementation is currently backward compatible and tell the user how to change the inputs.

In a future pull request, I can work on a script to convert the AeroDyn input files and do that for the r-test inputs.

ebranlard avatar Mar 14 '24 16:03 ebranlard

ToDo items

  • [x] address comments from @jjonkman above regarding SkewMod and SectAvgWeighting (@ebranlard)
  • [x] merge latest r-test into r-test branch (@andrew-platt)
  • [x] update remaining AD15 input files in r-test (@andrew-platt)
  • [x] address typos above (@andrew-platt)
  • [x] WrScr calls (@andrew-platt)

andrew-platt avatar Apr 02 '24 21:04 andrew-platt

@ebranlard, if/when you are done with the minor updates, I will plan on merging this in the next day or two.

andrew-platt avatar May 06 '24 17:05 andrew-platt

I've added a small converter for AD3.x to AD4.0 in the openfast_toolbox:

from openfast_toolbox.converters.versions.aerodyn import ad30_to_ad40
ad = ad30_to_ad40(fileold, filenew)

See example here.

ebranlard avatar May 08 '24 19:05 ebranlard